From: Chengguang Xu <cgxu519@mykernel.net>
To: jack@suse.com
Cc: linux-ext4@vger.kernel.org, Chengguang Xu <cgxu519@mykernel.net>
Subject: [PATCH v2] ext2: add missing brelse in ext2_new_blocks()
Date: Tue, 22 Oct 2019 17:17:38 +0800 [thread overview]
Message-ID: <20191022091738.9160-1-cgxu519@mykernel.net> (raw)
There is a missing brelse of bitmap_bh in the
case of retry.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
v1->v2:
- Add comment to explain why the fix is needed.
fs/ext2/balloc.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 924c1c765306..18e75adcd2f6 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -1313,6 +1313,13 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal,
if (free_blocks > 0) {
grp_target_blk = ((goal - le32_to_cpu(es->s_first_data_block)) %
EXT2_BLOCKS_PER_GROUP(sb));
+ /*
+ * In a special case that allocated blocks are in system zone,
+ * we will retry block allocation due to failing to pass sanity
+ * check. In this case, the bitmap_bh is non-null pointer and we
+ * have to release it before calling read_block_bitmap().
+ */
+ brelse(bitmap_bh);
bitmap_bh = read_block_bitmap(sb, group_no);
if (!bitmap_bh)
goto io_error;
--
2.20.1
next reply other threads:[~2019-10-22 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 9:17 Chengguang Xu [this message]
2019-10-22 9:25 ` [PATCH v2] ext2: add missing brelse in ext2_new_blocks() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022091738.9160-1-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox