From: Chengguang Xu <cgxu519@mykernel.net>
To: jack@suse.com
Cc: linux-ext4@vger.kernel.org, Chengguang Xu <cgxu519@mykernel.net>
Subject: [PATCH 3/5] ext2: skip unnecessary operations in ext2_try_to_allocate()
Date: Mon, 4 Nov 2019 19:40:34 +0800 [thread overview]
Message-ID: <20191104114036.9893-3-cgxu519@mykernel.net> (raw)
In-Reply-To: <20191104114036.9893-1-cgxu519@mykernel.net>
Move 'repeat' tag to proper place so that we can
skip unnecessary operations in ext2_try_to_allocate().
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/ext2/balloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 994a1fd18e93..a0c22e166682 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -696,7 +696,6 @@ ext2_try_to_allocate(struct super_block *sb, int group,
BUG_ON(start > EXT2_BLOCKS_PER_GROUP(sb));
-repeat:
if (grp_goal < 0) {
grp_goal = find_next_usable_block(start, bitmap_bh, end);
if (grp_goal < 0)
@@ -713,6 +712,7 @@ ext2_try_to_allocate(struct super_block *sb, int group,
}
start = grp_goal;
+repeat:
if (ext2_set_bit_atomic(sb_bgl_lock(EXT2_SB(sb), group), grp_goal,
bitmap_bh->b_data)) {
/*
--
2.20.1
next prev parent reply other threads:[~2019-11-04 11:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 11:40 [PATCH 1/5] ext2: introduce new helper ext2_group_last_block_no() Chengguang Xu
2019-11-04 11:40 ` [PATCH 2/5] ext2: code cleanup by calling ext2_group_last_block_no() Chengguang Xu
2019-11-06 15:42 ` Jan Kara
2019-11-07 2:54 ` Chengguang Xu
2019-11-07 9:21 ` Jan Kara
2019-11-07 9:44 ` Chengguang Xu
2019-11-07 11:36 ` Jan Kara
2019-11-04 11:40 ` Chengguang Xu [this message]
2019-11-04 11:40 ` [PATCH 4/5] ext2: code cleanup for ext2_try_to_allocate() Chengguang Xu
2019-11-06 15:59 ` Jan Kara
2019-11-07 2:58 ` Chengguang Xu
2019-11-04 11:40 ` [PATCH 5/5] ext2: fix improper function comment Chengguang Xu
2019-11-06 16:01 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104114036.9893-3-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).