From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A425C5DF60 for ; Tue, 5 Nov 2019 20:53:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4428621A49 for ; Tue, 5 Nov 2019 20:53:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729789AbfKEUxP (ORCPT ); Tue, 5 Nov 2019 15:53:15 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:57401 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725806AbfKEUxP (ORCPT ); Tue, 5 Nov 2019 15:53:15 -0500 Received: from callcc.thunk.org (ip-12-2-52-196.nyc.us.northamericancoax.com [196.52.2.12]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xA5Kr6PO004643 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 5 Nov 2019 15:53:07 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id DB589420311; Tue, 5 Nov 2019 15:53:03 -0500 (EST) Date: Tue, 5 Nov 2019 15:53:03 -0500 From: "Theodore Y. Ts'o" To: Matthew Bobrowski Cc: Jan Kara , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, riteshh@linux.ibm.com Subject: Re: [PATCH v7 11/11] ext4: introduce direct I/O write using iomap infrastructure Message-ID: <20191105205303.GA26959@mit.edu> References: <20191105135932.GN22379@quack2.suse.cz> <20191105203158.GA1739@bobrowski> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191105203158.GA1739@bobrowski> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Nov 06, 2019 at 07:32:00AM +1100, Matthew Bobrowski wrote: > > Otherwise you would write out and invalidate too much AFAICT - the 'offset' > > is position just before we fall back to buffered IO. Otherwise this hunk > > looks good to me. > > Er, yes. That's right, it should rather be 'err' instead or else we > would write/invalidate too much. I actually had this originally, but I > must've muddled it up while rewriting this patch on my other computer. > > Thanks for picking that up! I can fix that up in my tree, unless there are any other changes that we need to make. - Ted