From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 447EDC43331 for ; Mon, 11 Nov 2019 18:24:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26120214E0 for ; Mon, 11 Nov 2019 18:24:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726928AbfKKSY2 (ORCPT ); Mon, 11 Nov 2019 13:24:28 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:55736 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726821AbfKKSY2 (ORCPT ); Mon, 11 Nov 2019 13:24:28 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-98.corp.google.com [104.133.0.98] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xABIOH6Y022708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Nov 2019 13:24:18 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 16C0A4202FD; Mon, 11 Nov 2019 13:24:17 -0500 (EST) Date: Mon, 11 Nov 2019 13:24:17 -0500 From: "Theodore Y. Ts'o" To: Ritesh Harjani Cc: syzbot , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Jan Kara Subject: Re: general protection fault in ext4_writepages Message-ID: <20191111182417.GB5165@mit.edu> References: <00000000000073d3a70597069799@google.com> <20191111051236.2717D11C05B@d06av25.portsmouth.uk.ibm.com> <20191111053231.F129B11C04C@d06av25.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191111053231.F129B11C04C@d06av25.portsmouth.uk.ibm.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Nov 11, 2019 at 11:02:31AM +0530, Ritesh Harjani wrote: > > Updating the link. > > On 11/11/19 10:42 AM, Ritesh Harjani wrote: > > Hello Ted, > > > > This issue seems to be coming via fault injection failure in slab > > allocation. This should be fixed via below patch on your latest ext4 > > branch. > > > > https://marc.info/?l=linux-ext4&m=804&w=2 > https://marc.info/?l=linux-ext4&m=157303310723804&w=2 Agreed, although unfortunately I wasn't able to make the reproducer cause a failure _without_ the patch. Perhaps something other than enabling FAILSLAB and KASAN was needed? #syz test https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git test Let's see if the Syzbot can confirm that the patch addresses the problem. - Ted