From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0628C432C3 for ; Thu, 14 Nov 2019 17:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9657F206CC for ; Thu, 14 Nov 2019 17:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726214AbfKNR2A (ORCPT ); Thu, 14 Nov 2019 12:28:00 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:38934 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725601AbfKNR2A (ORCPT ); Thu, 14 Nov 2019 12:28:00 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-98.corp.google.com [104.133.0.98] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xAEHRs2I028128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Nov 2019 12:27:55 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id A58514202FD; Thu, 14 Nov 2019 12:27:54 -0500 (EST) Date: Thu, 14 Nov 2019 12:27:54 -0500 From: "Theodore Y. Ts'o" To: Jesse Grodman Cc: linux-ext4@vger.kernel.org Subject: Re: Suggested change for superblock journal hint Message-ID: <20191114172754.GB4579@mit.edu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Nov 14, 2019 at 05:05:06PM +0200, Jesse Grodman wrote: > Hi, > > I encountered the scenario that a full fsck check was being run > unnecessarily when the major / minor number of my external journal was > being fixed by fsck. This PR changes that so that this change does > trigger the full fsck run: github.com/tytso/e2fsprogs/pull/26 Hi Jessie, It's preferable that patches e2fsprogs be sent to the linux-ext4 list, so they can get reviewed by the full ext4 community. That being said, I will accept minor patches sent via a pull request if they full meet the requirements for kernel patches: https://www.kernel.org/doc/html/latest/process/submitting-patches.html Note in particular the requirements for the Developer's Certification of Origin (aka the Signed-off-by tag). That has specific legal meanings (for example, you are certifying that your employer allows you to contribute to open source projects, or at least, *this* open source project), so please take a close look at that. Cheers, - Ted