From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D77C43215 for ; Mon, 18 Nov 2019 18:14:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7789222AC for ; Mon, 18 Nov 2019 18:14:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574100843; bh=WZxqlzttko/t7K47E27WckLwF631L0ReSZl1x8L+sOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YKCa+/o3FArEHiLKolg1Isa2kNtt3lZl/kcJRTFB4blltgXZzunPjwjyck9TN2PPX x+fa7vCDl1MCCSuLt1fn5q6AHNV58OR1ktkTZz1Mc/rLhyjpye+7GXrnBtEawsW8XP FOoJe2Gl+TUUdZva6fTVl9Wu3gLxSxrk/tV2M10I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726767AbfKRSOD (ORCPT ); Mon, 18 Nov 2019 13:14:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:52464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbfKRSOD (ORCPT ); Mon, 18 Nov 2019 13:14:03 -0500 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E9E65222A4; Mon, 18 Nov 2019 18:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574100842; bh=WZxqlzttko/t7K47E27WckLwF631L0ReSZl1x8L+sOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u6vOHOV6ktxUb9heORDtsKoQ/z6ArKiQs+i7bmlG2wQA2tzuuSGHRDOKvq391UoSY 9BViUuNg+zIzMk3bFb7ar9tx5vhYOp34EEJ9k4nxuwKAyq5YH0xCJdTAB1PdlvdeFb v15IUmEsJZms5J6GntPM7NXh22mmkl/j8bBeyK0w= Date: Mon, 18 Nov 2019 10:14:00 -0800 From: Eric Biggers To: Jarkko Sakkinen Cc: linux-fscrypt@vger.kernel.org, "Theodore Y . Ts'o" , Jaegeuk Kim , Paul Crowley , Paul Lawrence , keyrings@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, David Howells , Ondrej Mosnacek , Ondrej Kozina Subject: Re: [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Message-ID: <20191118181359.GA184560@gmail.com> References: <20191107001259.115018-1-ebiggers@kernel.org> <20191115172832.GA21300@linux.intel.com> <20191115192227.GA150987@sol.localdomain> <20191115225319.GB29389@linux.intel.com> <20191115230430.GA217050@gmail.com> <20191118180102.GB5984@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191118180102.GB5984@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Nov 18, 2019 at 08:01:02PM +0200, Jarkko Sakkinen wrote: > On Fri, Nov 15, 2019 at 03:04:31PM -0800, Eric Biggers wrote: > > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote: > > > > > > > I'm working on an xfstest for this: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > > > > > > > It's not quite ready, though. I'll post it for review when it is. > > > > > > > > Someone is also planning to update Android userspace to use this. So if there > > > > are any issues from that, I'll hear about it. > > > > > > Cool. Can you combine this patch and matching test (once it is done) to > > > a patch set? > > > > > > > xfstests is developed separately from the kernel (different git repo and > > maintainer), so combining kernel and xfstests patches into the same patchset > > doesn't make sense. I can certainly send them out at the same time, though. > > Is there instructions somewhere how to build and run these tests? > > For me it is sufficient if you point a branch and have some kind > of instructions somewhere. > There are many ways to run xfstests, but I usually use kvm-xfstests. See the command to run the encryption tests here: https://www.kernel.org/doc/html/latest/filesystems/fscrypt.html#tests More details about kvm-xfstests are here: https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-xfstests.md But if you want to run tests which aren't included in the prebuilt kvm-xfstests test appliance yet (such as the test for this patch), it's not quite as straightforward since you'll also need to build your own test appliance: https://github.com/tytso/xfstests-bld/blob/master/Documentation/building-rootfs.md Also note that this test will require both xfstests and xfsprogs updates: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/log/?h=fscrypt-provisioning https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfsprogs-dev.git/log/?h=fscrypt-provisioning - Eric