From: "zhangyi (F)" <yi.zhang@huawei.com>
To: <linux-ext4@vger.kernel.org>
Cc: <jack@suse.com>, <tytso@mit.edu>, <adilger.kernel@dilger.ca>,
<yi.zhang@huawei.com>, <liangyun2@huawei.com>,
<luoshijie1@huawei.com>
Subject: [PATCH v3 0/4] ext4, jbd2: improve aborting progress
Date: Wed, 4 Dec 2019 20:46:10 +0800 [thread overview]
Message-ID: <20191204124614.45424-1-yi.zhang@huawei.com> (raw)
Hi,
This series originally aim to fix ext4_handle_error() and ext4_abort()
cannot panic because of we invoke __jbd2_journal_abort_hard() when we
failed to submit commit record without setting JBD2_REC_ERR flag.
I add patch 1 and patch 4 to switch to use jbd2_journal_abort() and do
some cleanup job at this iteration as Jan suggested. I also add patch 3
to fix missing updating ESHUTDOWN problem in commit 818d276ceb8 "ext4:
Add the journal checksum feature", please revirew this series and give
some suggestions.
Changes since v2:
- Fix spelling mistakes in the first patch.
- Keep JBD2_REC_ERR and remove the last place that invoke
jbd2_journal_abort() with 0 errno and the corresponding logic in
__journal_abort_soft().
- Fix missing updating errno in the jbd2 sb after jbd2 shutdown abort.
Thanks,
Yi.
zhangyi (F) (4):
jbd2: switch to use jbd2_journal_abort() when failed to submit the
commit record
ext4, jbd2: ensure panic when aborting with zero errno
jbd2: make sure ESHUTDOWN to be recorded in the journal superblock
jbd2: clean __jbd2_journal_abort_hard() and __journal_abort_soft()
fs/jbd2/checkpoint.c | 2 +-
fs/jbd2/commit.c | 4 +-
fs/jbd2/journal.c | 111 ++++++++++++++++---------------------------
include/linux/jbd2.h | 1 -
4 files changed, 45 insertions(+), 73 deletions(-)
--
2.17.2
next reply other threads:[~2019-12-04 12:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 12:46 zhangyi (F) [this message]
2019-12-04 12:46 ` [PATCH v3 1/4] jbd2: switch to use jbd2_journal_abort() when failed to submit the commit record zhangyi (F)
2020-01-25 7:58 ` Theodore Y. Ts'o
2019-12-04 12:46 ` [PATCH v3 2/4] ext4, jbd2: ensure panic when aborting with zero errno zhangyi (F)
2019-12-04 12:52 ` Jan Kara
2020-01-25 7:59 ` Theodore Y. Ts'o
2019-12-04 12:46 ` [PATCH v3 3/4] jbd2: make sure ESHUTDOWN to be recorded in the journal superblock zhangyi (F)
2019-12-04 17:05 ` Jan Kara
2019-12-05 1:23 ` zhangyi (F)
2019-12-23 1:44 ` zhangyi (F)
2020-01-25 8:00 ` Theodore Y. Ts'o
2019-12-04 12:46 ` [PATCH v3 4/4] jbd2: clean __jbd2_journal_abort_hard() and __journal_abort_soft() zhangyi (F)
2019-12-04 17:05 ` Jan Kara
2020-01-25 8:02 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204124614.45424-1-yi.zhang@huawei.com \
--to=yi.zhang@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.com \
--cc=liangyun2@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=luoshijie1@huawei.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).