From: "zhangyi (F)" <yi.zhang@huawei.com>
To: <linux-ext4@vger.kernel.org>
Cc: <jack@suse.cz>, <tytso@mit.edu>, <luoshijie1@huawei.com>,
<zhangxiaoxu5@huawei.com>, <yi.zhang@huawei.com>
Subject: [PATCH v2 0/2] jbd2: fix an oops problem
Date: Tue, 11 Feb 2020 21:54:58 +0800 [thread overview]
Message-ID: <20200211135500.40524-1-yi.zhang@huawei.com> (raw)
Changes since v1:
- Switch to clear b_modified just after set_buffer_freed() instead of
reuse codes at the end of journal_unmap_buffer().
- Switch to distinguish metadata buffers through the page mapping dev.
Thanks,
Yi.
--------------
Original description:
We encountered a jbd2 oops problem on an aarch64 machine with 4K block
size and 64K page size when doing stress tests.
Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008
...
user pgtable: 64k pages, 42-bit VAs, pgdp = (____ptrval____)
...
pc : jbd2_journal_put_journal_head+0x7c/0x284
lr : jbd2_journal_put_journal_head+0x3c/0x284
...
Call trace:
jbd2_journal_put_journal_head+0x7c/0x284
__jbd2_journal_refile_buffer+0x164/0x188
jbd2_journal_commit_transaction+0x12a0/0x1a50
kjournald2+0xd0/0x260
kthread+0x134/0x138
ret_from_fork+0x10/0x1c
Code: 51000400 b9000ac0 35000760 f9402274 (b9400a80)
---[ end trace 8fa99273d06aeb63 ]---
These patch set can fix this issue, the first patch is just a cleanup
patch, and the second one describe the root cause and fix it.
zhangyi (F) (2):
jbd2: move the clearing of b_modified flag to the
journal_unmap_buffer()
jbd2: do not clear the BH_Mapped flag when forgetting a metadata
buffer
fs/jbd2/commit.c | 41 ++++++++++++++++++++---------------------
fs/jbd2/transaction.c | 10 ++++++----
2 files changed, 26 insertions(+), 25 deletions(-)
--
2.17.2
next reply other threads:[~2020-02-11 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 13:54 zhangyi (F) [this message]
2020-02-11 13:54 ` [PATCH v2 1/2] jbd2: move the clearing of b_modified flag to the journal_unmap_buffer() zhangyi (F)
2020-02-12 10:45 ` Jan Kara
2020-02-11 13:55 ` [PATCH v2 2/2] jbd2: do not clear the BH_Mapped flag when forgetting a metadata buffer zhangyi (F)
2020-02-12 10:48 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211135500.40524-1-yi.zhang@huawei.com \
--to=yi.zhang@huawei.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=luoshijie1@huawei.com \
--cc=tytso@mit.edu \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).