* [PATCH] ext4: delete declaration for ext4_split_extent()
@ 2020-02-12 16:21 Eric Whitney
2020-02-12 17:02 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Eric Whitney @ 2020-02-12 16:21 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso, Eric Whitney
There are no forward references for ext4_split_extent() in extents.c,
so delete its unnecessary declaration.
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
fs/ext4/extents.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 89aa9c7ae293..a5338a8da2ab 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -83,13 +83,6 @@ static void ext4_extent_block_csum_set(struct inode *inode,
et->et_checksum = ext4_extent_block_csum(inode, eh);
}
-static int ext4_split_extent(handle_t *handle,
- struct inode *inode,
- struct ext4_ext_path **ppath,
- struct ext4_map_blocks *map,
- int split_flag,
- int flags);
-
static int ext4_split_extent_at(handle_t *handle,
struct inode *inode,
struct ext4_ext_path **ppath,
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: delete declaration for ext4_split_extent()
2020-02-12 16:21 [PATCH] ext4: delete declaration for ext4_split_extent() Eric Whitney
@ 2020-02-12 17:02 ` Darrick J. Wong
2020-03-05 21:28 ` Theodore Y. Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2020-02-12 17:02 UTC (permalink / raw)
To: Eric Whitney; +Cc: linux-ext4, tytso
On Wed, Feb 12, 2020 at 11:21:41AM -0500, Eric Whitney wrote:
> There are no forward references for ext4_split_extent() in extents.c,
> so delete its unnecessary declaration.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Looks good to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/ext4/extents.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 89aa9c7ae293..a5338a8da2ab 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -83,13 +83,6 @@ static void ext4_extent_block_csum_set(struct inode *inode,
> et->et_checksum = ext4_extent_block_csum(inode, eh);
> }
>
> -static int ext4_split_extent(handle_t *handle,
> - struct inode *inode,
> - struct ext4_ext_path **ppath,
> - struct ext4_map_blocks *map,
> - int split_flag,
> - int flags);
> -
> static int ext4_split_extent_at(handle_t *handle,
> struct inode *inode,
> struct ext4_ext_path **ppath,
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: delete declaration for ext4_split_extent()
2020-02-12 17:02 ` Darrick J. Wong
@ 2020-03-05 21:28 ` Theodore Y. Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2020-03-05 21:28 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eric Whitney, linux-ext4
On Wed, Feb 12, 2020 at 09:02:36AM -0800, Darrick J. Wong wrote:
> On Wed, Feb 12, 2020 at 11:21:41AM -0500, Eric Whitney wrote:
> > There are no forward references for ext4_split_extent() in extents.c,
> > so delete its unnecessary declaration.
> >
> > Signed-off-by: Eric Whitney <enwlinux@gmail.com>
>
> Looks good to me,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-05 21:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-12 16:21 [PATCH] ext4: delete declaration for ext4_split_extent() Eric Whitney
2020-02-12 17:02 ` Darrick J. Wong
2020-03-05 21:28 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).