From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB1D5C3F2CE for ; Wed, 4 Mar 2020 23:23:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9B64207FD for ; Wed, 4 Mar 2020 23:23:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388468AbgCDXX4 (ORCPT ); Wed, 4 Mar 2020 18:23:56 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:36848 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388412AbgCDXX4 (ORCPT ); Wed, 4 Mar 2020 18:23:56 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-105.corp.google.com [104.133.0.105] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 024NNq1n011948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 4 Mar 2020 18:23:53 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 97AC642045B; Wed, 4 Mar 2020 18:23:52 -0500 (EST) Date: Wed, 4 Mar 2020 18:23:52 -0500 From: "Theodore Y. Ts'o" To: Andreas Dilger Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 8/9] e2fsck: consistently use ext2fs_get_mem() Message-ID: <20200304232352.GG74069@mit.edu> References: <1581037786-62789-1-git-send-email-adilger@whamcloud.com> <1581037786-62789-8-git-send-email-adilger@whamcloud.com> <20200229233602.GH38945@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200229233602.GH38945@mit.edu> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Feb 29, 2020 at 06:36:02PM -0500, Theodore Y. Ts'o wrote: > On Thu, Feb 06, 2020 at 06:09:45PM -0700, Andreas Dilger wrote: > > Consistently use ext2fs_get_mem() and ext2fs_free_mem() instead of > > calling malloc() and free() directly in e2fsck. In several places > > it is possible to use ext2fs_get_memzero() instead of explicitly > > calling memset() on the memory afterward. > > > > This is just a code cleanup, and does not fix any specific bugs. > > > > Signed-off-by: Andreas Dilger > > Lustre-bug-id: https://jira.whamcloud.com/browse/LU-13197 > > Applied, thanks. I had to fix up this Makefile so that "make check" would properly link tst_region. - Ted