From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E89ABC3F2D1 for ; Fri, 6 Mar 2020 01:29:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAA862070E for ; Fri, 6 Mar 2020 01:29:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726317AbgCFB3F (ORCPT ); Thu, 5 Mar 2020 20:29:05 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:41217 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726259AbgCFB3F (ORCPT ); Thu, 5 Mar 2020 20:29:05 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-105.corp.google.com [104.133.0.105] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0261T01U005509 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Mar 2020 20:29:01 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id E08D742045B; Thu, 5 Mar 2020 20:28:59 -0500 (EST) Date: Thu, 5 Mar 2020 20:28:59 -0500 From: "Theodore Y. Ts'o" To: Eric Whitney Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: clean up error return for convert_initialized_extent() Message-ID: <20200306012859.GK20967@mit.edu> References: <20200218202656.21561-1-enwlinux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200218202656.21561-1-enwlinux@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Feb 18, 2020 at 03:26:56PM -0500, Eric Whitney wrote: > Although convert_initialized_extent() can potentially return an error > code with a negative value, its returned value is assigned to an > unsigned variable containing a block count in ext4_ext_map_blocks() and > then returned to that function's caller. The code currently works, > though the way this happens is obscure. The code would be more > readable if it followed the error handling convention used elsewhere > in ext4_ext_map_blocks(). > > This patch does not address any known test failure or bug report - it's > simply a cleanup. It also addresses a nearby coding standard issue. > > Signed-off-by: Eric Whitney Thanks, applied. - Ted