From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8CCC41621 for ; Tue, 24 Mar 2020 18:43:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7821320775 for ; Tue, 24 Mar 2020 18:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727662AbgCXSnt (ORCPT ); Tue, 24 Mar 2020 14:43:49 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:45309 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727379AbgCXSns (ORCPT ); Tue, 24 Mar 2020 14:43:48 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 02OIhPC4017362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Mar 2020 14:43:25 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 3E068420EBA; Tue, 24 Mar 2020 14:43:25 -0400 (EDT) Date: Tue, 24 Mar 2020 14:43:25 -0400 From: "Theodore Y. Ts'o" To: Christoph Hellwig Cc: Dave Chinner , Ext4 Developers List , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/2] writeback, xfs: call dirty_inode() with I_DIRTY_TIME_EXPIRED when appropriate Message-ID: <20200324184325.GF53396@mit.edu> References: <20200320024639.GH1067245@mit.edu> <20200320025255.1705972-1-tytso@mit.edu> <20200320025255.1705972-2-tytso@mit.edu> <20200323175838.GA7133@mit.edu> <20200324083759.GA32036@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324083759.GA32036@infradead.org> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Mar 24, 2020 at 01:37:59AM -0700, Christoph Hellwig wrote: > On Mon, Mar 23, 2020 at 01:58:38PM -0400, Theodore Y. Ts'o wrote: > > Christoph, Dave --- does this give you the notification that you were > > looking such that XFS could get the notification desired that it was > > the timestamps need to be written back? > > I need to look at it in more detail as it seems convoluted. Also the > order seems like you regress XFS in patch 1 and then fix it in patch 2? In patch one we send I_DIRTY_SYNC as we had been doing as before. So I don't believe that patch #1 would regress XFS; can you confirm? My thinking was to move ahead with patch 1 so that it fixed the bug which Eric Biffers had reported for f2fs, but only to move forward with patch #2 if it would be useful for XFS. Cheers, - Ted