From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Josh Triplett <josh@joshtriplett.org>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>
Subject: Re: [PATCH] ext4: Fix incorrect group count in ext4_fill_super error message
Date: Sun, 29 Mar 2020 12:44:54 -0400 [thread overview]
Message-ID: <20200329164454.GN53396@mit.edu> (raw)
In-Reply-To: <471D6886-24DF-4AC2-A5F2-DBE7C2B97AE8@dilger.ca>
On Sat, Mar 28, 2020 at 10:36:07PM -0600, Andreas Dilger wrote:
> You missed the v2 patch, which was better IMHO.
I saw the V2 patch, but the it will print the 32-bit truncated block
count, and it's possible if things are really insane, the number of
block groups calculated will be > 2**32. In which case the V1 patch
with the format string adjusted will print a less confusing message.
e.g.:
groups count too large: 8589934634 ....
as opposed to:
groups count too large: 42 ....
- Ted
prev parent reply other threads:[~2020-03-29 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 21:54 [PATCH] ext4: Fix incorrect group count in ext4_fill_super error message Josh Triplett
2020-03-28 22:44 ` kbuild test robot
2020-03-28 23:07 ` Andreas Dilger
2020-03-28 23:55 ` Josh Triplett
2020-03-29 2:47 ` Theodore Y. Ts'o
2020-03-29 4:36 ` Andreas Dilger
2020-03-29 16:44 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200329164454.GN53396@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=adilger@dilger.ca \
--cc=josh@joshtriplett.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).