From: Lukas Czerner <lczerner@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: Ted Tso <tytso@mit.edu>
Subject: [PATCH] e2scrub: Remove PATH setting from the scripts
Date: Thu, 2 Apr 2020 15:47:16 +0200 [thread overview]
Message-ID: <20200402134716.3725-1-lczerner@redhat.com> (raw)
We don't want to override system setting by changing the PATH. This
should remain under administrator/user control.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
scrub/e2scrub.in | 2 --
scrub/e2scrub_all.in | 2 --
2 files changed, 4 deletions(-)
diff --git a/scrub/e2scrub.in b/scrub/e2scrub.in
index 30ab7cbd..7c3f46e9 100644
--- a/scrub/e2scrub.in
+++ b/scrub/e2scrub.in
@@ -23,8 +23,6 @@
# check filesystems in VGs that have at least 256MB (or so) of
# free space.
-PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
-
if (( $EUID != 0 )); then
echo "e2scrub must be run as root"
exit 1
diff --git a/scrub/e2scrub_all.in b/scrub/e2scrub_all.in
index 4288b969..b6a7d0ad 100644
--- a/scrub/e2scrub_all.in
+++ b/scrub/e2scrub_all.in
@@ -18,8 +18,6 @@
# along with this program; if not, write the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
-PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
-
if (( $EUID != 0 )); then
echo "e2scrub_all must be run as root"
exit 1
--
2.21.1
next reply other threads:[~2020-04-02 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 13:47 Lukas Czerner [this message]
2020-04-02 15:17 ` [PATCH] e2scrub: Remove PATH setting from the scripts Darrick J. Wong
2020-04-10 16:16 ` Theodore Y. Ts'o
2020-04-16 9:38 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402134716.3725-1-lczerner@redhat.com \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).