From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: fix BUG_ON in fs/ext4/page_io.c:ext4_release_io_end()
Date: Mon, 13 Apr 2020 22:59:14 -0400 [thread overview]
Message-ID: <20200414025914.GE90651@mit.edu> (raw)
In-Reply-To: <20200414022842.272657-1-tytso@mit.edu>
On Mon, Apr 13, 2020 at 10:28:42PM -0400, Theodore Ts'o wrote:
> The function ext4_release_io_end() can be called by
> ext4_put_io_end_defer() with the EXT4_IO_UNWRITTEN flag set and
> io_end->size is 0. In that case, it's safe to release the io_end
> structure, since if io_end->size is zero, there is no unwritten region
> to release.
>
> This can be reproduced using generic/300, although not very reliably,
> and almost never using a freshly rebooted kernel.
>
> Google-Bug-Id: 15054006
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
NACK; this patch no longer applies given the move to use iomap for direct I/O.
- Ted
next prev parent reply other threads:[~2020-04-14 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 2:28 [PATCH] ext4: fix BUG_ON in fs/ext4/page_io.c:ext4_release_io_end() Theodore Ts'o
2020-04-14 2:59 ` Theodore Y. Ts'o [this message]
2020-04-14 4:11 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414025914.GE90651@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).