From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C447C2BA2B for ; Wed, 15 Apr 2020 06:46:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54780206D9 for ; Wed, 15 Apr 2020 06:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2635012AbgDOGqv (ORCPT ); Wed, 15 Apr 2020 02:46:51 -0400 Received: from mga06.intel.com ([134.134.136.31]:21756 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2634963AbgDOGpm (ORCPT ); Wed, 15 Apr 2020 02:45:42 -0400 IronPort-SDR: Ti/gLW04uzxuEDdmIfUM0pDEa/Q96hu7i9tkF/KuHtYMsTP7MuyVE1ggiGSZrAKVR2iNqs0K// s3FNlGwuXTXg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 23:45:41 -0700 IronPort-SDR: meDbPnYHnawnM5CRSIMJnVXkGzjNZlVB1YKzuHRAQvu6g+oOQhno9/fZDNwEyJ9fUXgCcPNee4 CjwOFm/qdXYg== X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="245617315" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 23:45:41 -0700 From: ira.weiny@intel.com To: linux-kernel@vger.kernel.org, "Darrick J. Wong" Cc: Ira Weiny , Jan Kara , Dan Williams , Dave Chinner , Christoph Hellwig , "Theodore Y. Ts'o" , Jeff Moyer , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH V8 09/11] fs: Introduce DCACHE_DONTCACHE Date: Tue, 14 Apr 2020 23:45:21 -0700 Message-Id: <20200415064523.2244712-10-ira.weiny@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415064523.2244712-1-ira.weiny@intel.com> References: <20200415064523.2244712-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Ira Weiny DCACHE_DONTCACHE indicates a dentry should not be cached on final dput(). Also add a helper function which will flag I_DONTCACHE as well ad DCACHE_DONTCACHE on all dentries point to a specified inode. Signed-off-by: Ira Weiny --- Changes from V7: new patch --- fs/dcache.c | 4 ++++ fs/inode.c | 15 +++++++++++++++ include/linux/dcache.h | 2 ++ include/linux/fs.h | 1 + 4 files changed, 22 insertions(+) diff --git a/fs/dcache.c b/fs/dcache.c index b280e07e162b..0030fabab2c4 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -647,6 +647,10 @@ static inline bool retain_dentry(struct dentry *dentry) if (dentry->d_op->d_delete(dentry)) return false; } + + if (unlikely(dentry->d_flags & DCACHE_DONTCACHE)) + return false; + /* retain; LRU fodder */ dentry->d_lockref.count--; if (unlikely(!(dentry->d_flags & DCACHE_LRU_LIST))) diff --git a/fs/inode.c b/fs/inode.c index 93d9252a00ab..b8b1917a324e 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1526,6 +1526,21 @@ int generic_delete_inode(struct inode *inode) } EXPORT_SYMBOL(generic_delete_inode); +void flag_inode_dontcache(struct inode *inode) +{ + struct dentry *dent; + + rcu_read_lock(); + hlist_for_each_entry(dent, &inode->i_dentry, d_u.d_alias) { + spin_lock(&dent->d_lock); + dent->d_flags |= DCACHE_DONTCACHE; + spin_unlock(&dent->d_lock); + } + rcu_read_unlock(); + inode->i_state |= I_DONTCACHE; +} +EXPORT_SYMBOL(flag_inode_dontcache); + /* * Called when we're dropping the last reference * to an inode. diff --git a/include/linux/dcache.h b/include/linux/dcache.h index c1488cc84fd9..56b1482d9223 100644 --- a/include/linux/dcache.h +++ b/include/linux/dcache.h @@ -177,6 +177,8 @@ struct dentry_operations { #define DCACHE_REFERENCED 0x00000040 /* Recently used, don't discard. */ +#define DCACHE_DONTCACHE 0x00000080 /* don't cache on final dput() */ + #define DCACHE_CANT_MOUNT 0x00000100 #define DCACHE_GENOCIDE 0x00000200 #define DCACHE_SHRINK_LIST 0x00000400 diff --git a/include/linux/fs.h b/include/linux/fs.h index e2db71d150c3..f2916c99616a 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3048,6 +3048,7 @@ static inline int generic_drop_inode(struct inode *inode) return !inode->i_nlink || inode_unhashed(inode) || (inode->i_state & I_DONTCACHE); } +extern void flag_inode_dontcache(struct inode *inode); extern struct inode *ilookup5_nowait(struct super_block *sb, unsigned long hashval, int (*test)(struct inode *, void *), -- 2.25.1