From: Lukas Czerner <lczerner@redhat.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2scrub: Remove PATH setting from the scripts
Date: Thu, 16 Apr 2020 11:38:40 +0200 [thread overview]
Message-ID: <20200416093840.y5w2azeivn6mhbnu@work> (raw)
In-Reply-To: <20200410161635.GP45598@mit.edu>
On Fri, Apr 10, 2020 at 12:16:35PM -0400, Theodore Y. Ts'o wrote:
> On Thu, Apr 02, 2020 at 03:47:16PM +0200, Lukas Czerner wrote:
> > We don't want to override system setting by changing the PATH. This
> > should remain under administrator/user control.
> >
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
>
> The reason why the PATH was added is because most users don't have
> /sbin or /usr/sbin in their PATH, and if they run "sudo e2scrub",
> finding commands like lvcreate, lvremove, et. al., wouldn't be there.
I don't understand, e2scrub should be in be in sbin as well, right ?
Besides what if such user wants to run lvcreate, or lvremove ? This
seems like a problem that should be fixed somewhere else.
>
> I suppose we could do something like
>
> PATH=$PATH:/sbin:/usr/sbin
that's better than replacing it.
-Lukas
>
> instead, but otherwise, users will see some unexpected failures.
>
> - Ted
>
prev parent reply other threads:[~2020-04-16 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 13:47 [PATCH] e2scrub: Remove PATH setting from the scripts Lukas Czerner
2020-04-02 15:17 ` Darrick J. Wong
2020-04-10 16:16 ` Theodore Y. Ts'o
2020-04-16 9:38 ` Lukas Czerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416093840.y5w2azeivn6mhbnu@work \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox