Re: [PATCH V10 02/11] fs: Remove unneeded IS_DAX() check in io_is_direct()

Dave Chinner
2020-04-23T21:41:21Z

On Wed, Apr 22, 2020 at 02:20:53PM -0700, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> Remove the check because DAX now has it's own read/write methods and
> file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on
> their own. Therefore, it does not matter if the file state is DAX when
> the iocb flags are created.
>
> Also remove io_is_direct() as it is just a simple flag check.
>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com