From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18518C5519A for ; Mon, 27 Apr 2020 06:28:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E06B2208FE for ; Mon, 27 Apr 2020 06:28:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FAiKdO7K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726537AbgD0G2N (ORCPT ); Mon, 27 Apr 2020 02:28:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbgD0G2N (ORCPT ); Mon, 27 Apr 2020 02:28:13 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6FBFC061A0F; Sun, 26 Apr 2020 23:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vJpMkjG5DX5/M9LM8IYv/octmqJf4nqFAaGXSYoBAyA=; b=FAiKdO7KxOvy52OFUxVf9h5LdX 02z9fddnhmmnCI1wuBUQNZChoTN44UpCMRw3U3uX6KdOewnCEaf0rwlwXad7Eq51cZT82r2VsV3hH JyYk5zxK0U0lxr+9kYTci5PyBNhk1ca4LHPoiQIBa4v7eaXCV8EHzIDlE8iZhmlJxat7R/nw5c6Bh VXs7nDmnQq3WSK1ut2L7k7xHkHNFvdL5HoSwDGoYyflTSUK2iwO+/E5/ItkvvtIIyB077rYKvxTVP breU9IKaBMcAfgRzLQKZib3d75Uarh4ixv51EGcZeHpd9fUSD6J1ftW0jRQbe3BW8lJlq1To8jqBw gpsP8V4g==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSxFS-0004Rw-7w; Mon, 27 Apr 2020 06:28:10 +0000 Date: Sun, 26 Apr 2020 23:28:10 -0700 From: Christoph Hellwig To: Amir Goldstein Cc: Christoph Hellwig , Ritesh Harjani , Ext4 , Jan Kara , Theodore Tso , Andreas Dilger , "Darrick J. Wong" , Alexander Viro , Dan Carpenter , "Aneesh Kumar K . V" , Murphy Zhou , Miklos Szeredi , linux-fsdevel , overlayfs Subject: Re: [PATCH 0/5] ext4/overlayfs: fiemap related fixes Message-ID: <20200427062810.GA12930@infradead.org> References: <20200424101153.GC456@infradead.org> <20200424232024.A39974C046@d06av22.portsmouth.uk.ibm.com> <20200425094350.GA11881@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Apr 25, 2020 at 01:49:43PM +0300, Amir Goldstein wrote: > I would use as generic helper name generic_fiemap_checks() > akin to generic_write_checks() and generic_remap_file_range_prep() => > generic_remap_checks(). None of the other fiemap helpers use the redundant generic_ prefix.