From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DE1FC55199 for ; Mon, 27 Apr 2020 06:42:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA760208FE for ; Mon, 27 Apr 2020 06:42:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="fxJqCL+r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726625AbgD0Gmd (ORCPT ); Mon, 27 Apr 2020 02:42:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbgD0Gmd (ORCPT ); Mon, 27 Apr 2020 02:42:33 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C78BC061A0F; Sun, 26 Apr 2020 23:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=8XXy6DGHElkvvG3uRrBPJZZu9JuV2U/fqGOHJLpjlME=; b=fxJqCL+rgYyFO2hMnH5w4KcO0W e4oSzIclMzPkRxjG8/QAk9z3YkuxqXT3VfOkdyr2OoV65OLqQa0wQ7NipthQ2FBb+KQ8sQ239GF6N +6KGZZOeEoPV73F63KUN2awAD4XDdASc8P9N0euTkSQzyUyiIkgTRlXVrWzGEQeQ0Lu/x+WXRkovb iuRQUCrZIaRl7oUXgSoGwWZe7KtAE8FwlCVgZV/Bo+v0Cophs30Zbl/Hd4+QwCoESGMtoPry0vO9G Zf0EN+r2ZMMKpjq+GJJkJCNfypeh8QEFjUqp06l+YA4GCk9MgYqje4jhKhX3+DNd11kDajyDlKmet zNBqMpjQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSxTL-0005WD-SY; Mon, 27 Apr 2020 06:42:31 +0000 Date: Sun, 26 Apr 2020 23:42:31 -0700 From: Christoph Hellwig To: Andreas Dilger Cc: Christoph Hellwig , Amir Goldstein , Ritesh Harjani , Ext4 , Jan Kara , Theodore Tso , "Darrick J. Wong" , Alexander Viro , Dan Carpenter , "Aneesh Kumar K . V" , Murphy Zhou , Miklos Szeredi , linux-fsdevel , overlayfs Subject: Re: [PATCH 0/5] ext4/overlayfs: fiemap related fixes Message-ID: <20200427064231.GA19581@infradead.org> References: <20200425094350.GA11881@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Apr 25, 2020 at 10:32:44AM -0700, Andreas Dilger wrote: > On Apr 25, 2020, at 02:43, Christoph Hellwig wrote: > > > > On Sat, Apr 25, 2020 at 12:11:59PM +0300, Amir Goldstein wrote: > >> FWIW, I agree with you. > >> And seems like Jan does as well, since he ACKed all your patches. > >> Current patches would be easier to backport to stable kernels. > > > > Honestly, the proper fix is pretty much trivial. I wrote it up this > > morning over coffee: > > > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/fiemap-fix > > > > Still needs more testing, though. > > The "maxbytes" value should be passed in from the caller, since this > may be different per inode (for ext4 at least). We should handle it, but not burden everyone else who has saner limits.