From: Christoph Hellwig <hch@infradead.org>
To: Ian Kent <raven@themaw.net>
Cc: Lukas Czerner <lczerner@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-ext4@vger.kernel.org, dhowells@redhat.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2 05/17] ext4: Allow sb to be NULL in ext4_msg()
Date: Wed, 29 Apr 2020 04:09:47 -0700 [thread overview]
Message-ID: <20200429110947.GA6290@infradead.org> (raw)
In-Reply-To: <4f6598e12127cc6e80af7dde5149220d92b07b11.camel@themaw.net>
On Wed, Apr 29, 2020 at 10:53:00AM +0800, Ian Kent wrote:
> The mount-API log macros tend to cause user confusion because they
> often lead to unexpected log messages.
>
> We're seeing that now with bugs logged due to unexpected messages
> resulting from the NFS mount-API conversion.
>
> I'd recommend mostly avoiding using the macros until there's been
> time to reconsider how they should work, after all fsopen() and
> friends will still get errno errors just not the passed string
> description.
And when is that time going to be? Should we convert existing users
back and remove that functionality if it doesn't work properly?
next prev parent reply other threads:[~2020-04-29 11:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 16:45 [PATCH v2 00/17] ext4: new mount API conversion Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 01/17] fs_parse: allow parameter value to be empty Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 02/17] ext4: Add fs parameter specifications for mount options Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 03/17] ext4: move option validation to a separate function Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 04/17] ext4: Change handle_mount_opt() to use fs_parameter Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 05/17] ext4: Allow sb to be NULL in ext4_msg() Lukas Czerner
2020-04-28 16:48 ` Christoph Hellwig
2020-04-28 16:57 ` Lukas Czerner
2020-04-29 2:53 ` Ian Kent
2020-04-29 11:09 ` Christoph Hellwig [this message]
2020-04-29 2:38 ` Eric Sandeen
2020-04-29 11:02 ` Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 06/17] ext4: move quota configuration out of handle_mount_opt() Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 07/17] ext4: check ext2/3 compatibility outside handle_mount_opt() Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 08/17] ext4: get rid of super block and sbi from handle_mount_ops() Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 09/17] ext4: parse Opt_sb in handle_mount_opt() Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 10/17] ext4: clean up return values " Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 11/17] ext4: add ext4_get_tree for the new mount API Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 12/17] ext4: refactor ext4_remount() Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 13/17] ext4: add ext4_reconfigure for the new mount API Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 14/17] ext4: add ext4_fc_free " Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 15/17] ext4: change token2str() to use ext4_param_specs Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 16/17] ext4: switch to the new mount API Lukas Czerner
2020-04-28 16:45 ` [PATCH v2 17/17] ext4: Remove unused code from old mount api Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429110947.GA6290@infradead.org \
--to=hch@infradead.org \
--cc=dhowells@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=raven@themaw.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).