From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jonny Grant <jg@jguk.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: /fs/ext4/namei.c ext4_find_dest_de()
Date: Sun, 3 May 2020 21:51:22 -0400 [thread overview]
Message-ID: <20200504015122.GB404484@mit.edu> (raw)
In-Reply-To: <2edc7d6a-289e-57ad-baf1-477dc240474d@jguk.org>
On Sun, May 03, 2020 at 02:00:25PM +0100, Jonny Grant wrote:
> Hi
>
> I noticed that mkdir() returns EEXIST if a directory already exists.
> strerror(EEXIST) text is "File exists"
>
> Can ext4_find_dest_de() be amended to return EISDIR if a directory already
> exists? This will make the error message clearer.
No; this will confuse potentially a large number of existing programs.
Also, the current behavior is required by POSIx and the Single Unix
Specification standards.
https://pubs.opengroup.org/onlinepubs/009695399/
Regards,
- Ted
next prev parent reply other threads:[~2020-05-04 1:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 13:00 /fs/ext4/namei.c ext4_find_dest_de() Jonny Grant
2020-05-04 1:51 ` Theodore Y. Ts'o [this message]
2020-05-04 7:38 ` Jonny Grant
2020-05-04 19:52 ` Theodore Y. Ts'o
2020-05-05 18:07 ` Jonny Grant
2020-05-05 18:50 ` Andreas Dilger
2020-05-07 11:25 ` Jonny Grant
2020-05-27 21:25 ` Jonny Grant
2020-05-28 1:12 ` Theodore Y. Ts'o
2020-06-08 1:39 ` Jonny Grant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504015122.GB404484@mit.edu \
--to=tytso@mit.edu \
--cc=jg@jguk.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).