From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix EXT_MAX_EXTENT/INDEX to check for zeroed eh_max
Date: Thu, 14 May 2020 10:49:41 -0400 [thread overview]
Message-ID: <20200514144941.GT1596452@mit.edu> (raw)
In-Reply-To: <20200421023959.20879-2-harshadshirwadkar@gmail.com>
On Mon, Apr 20, 2020 at 07:39:59PM -0700, Harshad Shirwadkar wrote:
> If eh->eh_max is 0, EXT_MAX_EXTENT/INDEX would evaluate to unsigned
> (-1) resulting in illegal memory accesses. Although there is no
> consistent repro, we see that generic/019 sometimes crashes because of
> this bug.
>
> Ran gce-xfstests smoke and verified that there were no regressions.
>
> Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2020-05-14 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 2:39 [PATCH] ext4: don't ignore return values from ext4_ext_dirty() Harshad Shirwadkar
2020-04-21 2:39 ` [PATCH] ext4: fix EXT_MAX_EXTENT/INDEX to check for zeroed eh_max Harshad Shirwadkar
2020-05-14 14:49 ` Theodore Y. Ts'o [this message]
2020-04-21 3:02 ` [PATCH] ext4: don't ignore return values from ext4_ext_dirty() harshad shirwadkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514144941.GT1596452@mit.edu \
--to=tytso@mit.edu \
--cc=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).