From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97715C433DF for ; Wed, 17 Jun 2020 14:09:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7411D20734 for ; Wed, 17 Jun 2020 14:09:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="d+J+aw6Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbgFQOJH (ORCPT ); Wed, 17 Jun 2020 10:09:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbgFQOJF (ORCPT ); Wed, 17 Jun 2020 10:09:05 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 215EAC0613EF for ; Wed, 17 Jun 2020 07:09:02 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id t18so2492241wru.6 for ; Wed, 17 Jun 2020 07:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Q/YL4Tzx4ADMiyqvj4Ve2wziFTGT/p0DVcYFG6HXk08=; b=d+J+aw6Zm5XRvlxRf1UGsdkDdw/4mdWlAseuLVRmjuRl77imTs8xnEwfCx3+/GfmIn bikdBwRjyQV2FhPxZDoxaryjSxXvxqhpXbUEuGGRJ6XKTOw9aHhfZNDGhlxVfd4s8+dB zPJBHP+Y5JfMrXFtfl1BiiRwc2CLhSP1/aSVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q/YL4Tzx4ADMiyqvj4Ve2wziFTGT/p0DVcYFG6HXk08=; b=jHuyW7NAoIpbV/isE5+hgO6WoMI4rITm5ZHstt/TAno/my1rrG36zDin+mD2Gocoz1 JqUTmzolQe4rzIg542tZDp0oSRTCHAUG5P4Quk+ALyECIFIeAC+6iUjcS7adLdREht5F XMli+r5xfAI3wLmR9EkPA3JexMvL6ZsFDhYyaTjzmTkxAZcZtIRKfr6GOrTGj/oJHxhz vnAhMMfkpf8KJVnlt10HiWjBtJWEGjmZhdr3/rlDpizQ7M1OyOkii2d2w7J1uodqrKqx wuweJtR8FcBymMc3nsAq5Q76LWT3ASuOjNOC/pwxozc5elv8VzUgWjRM8KWJuHCZ1qPZ yTow== X-Gm-Message-State: AOAM530vyAXhAlX7uscmm6OJfOUBFptYgEk9p8VMz7vVxJk791INYOjq rYAufO2HSxj8L9317W3rktw7VQ== X-Google-Smtp-Source: ABdhPJzL0eIzzTI+SzZBoqt3/b7Xundx14ukkyOPthT2L2+/VFT7bPwecalJL/jau7TXAMBO1wA5IA== X-Received: by 2002:adf:fd48:: with SMTP id h8mr9338191wrs.226.1592402940724; Wed, 17 Jun 2020 07:09:00 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id o6sm33035118wrp.3.2020.06.17.07.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 07:08:59 -0700 (PDT) Date: Wed, 17 Jun 2020 15:08:59 +0100 From: Chris Down To: Michal Hocko Cc: Naresh Kamboju , Yafang Shao , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , Cgroups Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200617140859.GB548179@chrisdown.name> References: <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> <20200520190906.GA558281@chrisdown.name> <20200521095515.GK6462@dhcp22.suse.cz> <20200521163450.GV6462@dhcp22.suse.cz> <20200617135951.GP9499@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200617135951.GP9499@dhcp22.suse.cz> User-Agent: Mutt/1.14.3 (2020-06-14) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Michal Hocko writes: >and it makes some sense. Except for the root memcg where we do not >account any memory. Adding if (mem_cgroup_is_root(memcg)) return false; >should do the trick. The same is the case for mem_cgroup_below_low. >Could you give it a try please just to confirm? Oh, of course :-) This seems more likely than what I proposed, and would be great to test.