From: tytso@mit.edu
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Alex Zhuravlev <bzzz@whamcloud.com>,
Shuichi Ihara <sihara@ddn.com>
Subject: Re: [PATCH 1/4] ext4: add prefetching for block allocation bitmaps
Date: Thu, 23 Jul 2020 11:00:06 -0400 [thread overview]
Message-ID: <20200723150006.GF1536749@mit.edu> (raw)
In-Reply-To: <1F791FDF-75A7-48D9-A0A7-764D5AEC8E4B@dilger.ca>
On Tue, Jul 21, 2020 at 01:42:54AM -0600, Andreas Dilger wrote:
>
> I re-reviewed the patch with the changes, and it looks OK. I see that
> you reduced the prefetch limit from 32 to 4 group blocks, presumably to
> keep the latency low? It would be useful to see what impact that has
> on the mount time and IO performance of a large filesystem.
No, I didn't change it. As before, it's 4 times the size of the
flex_bg size (assuming the file system has flex bg's enabled);
otherwise it's 128 (4 times 32).
I'm actually worried that this is too aggressive on storage devies
where LBA's which are adjacent to each other aren't necessarily
adjacent to each other on the physical storage device. For example,
on dm-thin, some qemu-img formats, and potentially some cloud virtual
block devices....
Unfortunately, there isn't a good way to query a block device to
determine whether adjacent LBA's are really adjacent in the real world.
- Ted
next prev parent reply other threads:[~2020-07-23 15:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 15:53 [PATCH 0/4] ex4 block bitmap prefetching Theodore Ts'o
2020-07-17 15:53 ` [PATCH 1/4] ext4: add prefetching for block allocation bitmaps Theodore Ts'o
2020-07-17 21:55 ` kernel test robot
2020-07-21 7:42 ` Andreas Dilger
2020-07-23 0:36 ` Shuichi Ihara
2020-07-23 15:00 ` tytso [this message]
2020-07-17 15:53 ` [PATCH 2/4] ext4: skip non-loaded groups at cr=0/1 when scanning for good groups Theodore Ts'o
2020-07-21 7:48 ` Andreas Dilger
2020-07-24 11:27 ` Благодаренко Артём
2020-07-17 15:53 ` [PATCH 3/4] ext4: indicate via a block bitmap read is prefetched via a tracepoint Theodore Ts'o
2020-07-21 7:51 ` Andreas Dilger
2020-07-24 12:04 ` Благодаренко Артём
2020-07-17 15:53 ` [PATCH 4/4] ext4: add prefetch_block_bitmaps mount options Theodore Ts'o
2020-07-21 8:20 ` Andreas Dilger
2020-07-24 13:58 ` Благодаренко Артём
-- strict thread matches above, loose matches on Subject: below --
2020-07-31 19:08 [PATCH 0/4] V2- ext4 block bitmap prefetch patches Theodore Ts'o
2020-07-31 19:08 ` [PATCH 1/4] ext4: add prefetching for block allocation bitmaps Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723150006.GF1536749@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=bzzz@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sihara@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).