From: Jan Kara <jack@suse.cz>
To: Xianting Tian <xianting_tian@126.com>
Cc: tytso@mit.edu, jack@suse.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jbd2: fix incorrect code style
Date: Mon, 27 Jul 2020 10:35:44 +0200 [thread overview]
Message-ID: <20200727083544.GD23179@quack2.suse.cz> (raw)
In-Reply-To: <1595077057-8048-1-git-send-email-xianting_tian@126.com>
On Sat 18-07-20 08:57:37, Xianting Tian wrote:
> Remove unnecessary blank.
>
> Signed-off-by: Xianting Tian <xianting_tian@126.com>
Looks fine. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/jbd2/journal.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index e494443..5eccf8c 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1285,7 +1285,7 @@ journal_t *jbd2_journal_init_inode(struct inode *inode)
> * superblock as being NULL to prevent the journal destroy from writing
> * back a bogus superblock.
> */
> -static void journal_fail_superblock (journal_t *journal)
> +static void journal_fail_superblock(journal_t *journal)
> {
> struct buffer_head *bh = journal->j_sb_buffer;
> brelse(bh);
> @@ -1815,7 +1815,7 @@ int jbd2_journal_destroy(journal_t *journal)
>
>
> /**
> - *int jbd2_journal_check_used_features () - Check if features specified are used.
> + *int jbd2_journal_check_used_features() - Check if features specified are used.
> * @journal: Journal to check.
> * @compat: bitmask of compatible features
> * @ro: bitmask of features that force read-only mount
> @@ -1825,7 +1825,7 @@ int jbd2_journal_destroy(journal_t *journal)
> * features. Return true (non-zero) if it does.
> **/
>
> -int jbd2_journal_check_used_features (journal_t *journal, unsigned long compat,
> +int jbd2_journal_check_used_features(journal_t *journal, unsigned long compat,
> unsigned long ro, unsigned long incompat)
> {
> journal_superblock_t *sb;
> @@ -1860,7 +1860,7 @@ int jbd2_journal_check_used_features (journal_t *journal, unsigned long compat,
> * all of a given set of features on this journal. Return true
> * (non-zero) if it can. */
>
> -int jbd2_journal_check_available_features (journal_t *journal, unsigned long compat,
> +int jbd2_journal_check_available_features(journal_t *journal, unsigned long compat,
> unsigned long ro, unsigned long incompat)
> {
> if (!compat && !ro && !incompat)
> @@ -1882,7 +1882,7 @@ int jbd2_journal_check_available_features (journal_t *journal, unsigned long com
> }
>
> /**
> - * int jbd2_journal_set_features () - Mark a given journal feature in the superblock
> + * int jbd2_journal_set_features() - Mark a given journal feature in the superblock
> * @journal: Journal to act on.
> * @compat: bitmask of compatible features
> * @ro: bitmask of features that force read-only mount
> @@ -1893,7 +1893,7 @@ int jbd2_journal_check_available_features (journal_t *journal, unsigned long com
> *
> */
>
> -int jbd2_journal_set_features (journal_t *journal, unsigned long compat,
> +int jbd2_journal_set_features(journal_t *journal, unsigned long compat,
> unsigned long ro, unsigned long incompat)
> {
> #define INCOMPAT_FEATURE_ON(f) \
> --
> 1.8.3.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-07-27 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 12:57 [PATCH] jbd2: fix incorrect code style Xianting Tian
2020-07-27 8:35 ` Jan Kara [this message]
2020-08-06 5:48 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727083544.GD23179@quack2.suse.cz \
--to=jack@suse.cz \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xianting_tian@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).