From: tytso@mit.edu
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: <linux-ext4@vger.kernel.org>, <jack@suse.cz>,
<jiufei.xue@linux.alibaba.com>
Subject: Re: [PATCH] jbd2: add the missing unlock_buffer() in the error path of jbd2_write_superblock()
Date: Thu, 6 Aug 2020 00:16:14 -0400 [thread overview]
Message-ID: <20200806041614.GB7657@mit.edu> (raw)
In-Reply-To: <20200620061948.2049579-1-yi.zhang@huawei.com>
On Sat, Jun 20, 2020 at 02:19:48PM +0800, zhangyi (F) wrote:
> jbd2_write_superblock() is under the buffer lock of journal superblock
> before ending that superblock write, so add a missing unlock_buffer() in
> in the error path before submitting buffer.
>
> Fixes: 742b06b5628f ("jbd2: check superblock mapped prior to committing")
> Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
> Cc: stable@kernel.org
Thanks, applied.
- Ted
prev parent reply other threads:[~2020-08-06 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 6:19 [PATCH] jbd2: add the missing unlock_buffer() in the error path of jbd2_write_superblock() zhangyi (F)
2020-07-08 11:03 ` Ritesh Harjani
2020-08-06 4:16 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806041614.GB7657@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=jiufei.xue@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).