From: Kyoungho Koo <rnrudgh@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger.kernel@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH] ext4: remove unused parameter of ext4_generic_delete_entry function
Date: Mon, 10 Aug 2020 17:07:05 +0900 [thread overview]
Message-ID: <20200810080701.GA14160@koo-Z370-HD3> (raw)
The ext4_generic_delete_entry function defines the handle_t type
variable, handle, as a parameter, but it is not used.
Signed-off-by: Kyoungho Koo <rnrudgh@gmail.com>
---
fs/ext4/ext4.h | 3 +--
fs/ext4/inline.c | 2 +-
fs/ext4/namei.c | 6 ++----
3 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 5148cbb0b4b3..feda8b65924b 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2764,8 +2764,7 @@ extern int ext4_search_dir(struct buffer_head *bh,
struct ext4_filename *fname,
unsigned int offset,
struct ext4_dir_entry_2 **res_dir);
-extern int ext4_generic_delete_entry(handle_t *handle,
- struct inode *dir,
+extern int ext4_generic_delete_entry(struct inode *dir,
struct ext4_dir_entry_2 *de_del,
struct buffer_head *bh,
void *entry_buf,
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index c3a1ad2db122..13054653a06a 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -1706,7 +1706,7 @@ int ext4_delete_inline_entry(handle_t *handle,
if (err)
goto out;
- err = ext4_generic_delete_entry(handle, dir, de_del, bh,
+ err = ext4_generic_delete_entry(dir, de_del, bh,
inline_start, inline_size, 0);
if (err)
goto out;
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 56738b538ddf..f5e60c622ce2 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2455,8 +2455,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
* ext4_generic_delete_entry deletes a directory entry by merging it
* with the previous entry
*/
-int ext4_generic_delete_entry(handle_t *handle,
- struct inode *dir,
+int ext4_generic_delete_entry(struct inode *dir,
struct ext4_dir_entry_2 *de_del,
struct buffer_head *bh,
void *entry_buf,
@@ -2517,8 +2516,7 @@ static int ext4_delete_entry(handle_t *handle,
if (unlikely(err))
goto out;
- err = ext4_generic_delete_entry(handle, dir, de_del,
- bh, bh->b_data,
+ err = ext4_generic_delete_entry(dir, de_del, bh, bh->b_data,
dir->i_sb->s_blocksize, csum_size);
if (err)
goto out;
--
2.17.1
next reply other threads:[~2020-08-10 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 8:07 Kyoungho Koo [this message]
2020-08-10 8:38 ` [PATCH] ext4: remove unused parameter of ext4_generic_delete_entry function Ritesh Harjani
2020-08-18 18:26 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810080701.GA14160@koo-Z370-HD3 \
--to=rnrudgh@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).