* [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment
@ 2020-08-07 14:01 brookxu
2020-08-13 8:20 ` Andreas Dilger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: brookxu @ 2020-08-07 14:01 UTC (permalink / raw)
To: adilger.kernel, tytso, linux-ext4
Fix typos in ext4_mb_regular_allocator() comment
Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
fs/ext4/mballoc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 4f21f34..0edec26 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2237,8 +2237,8 @@ static int ext4_mb_good_group_nolock(struct ext4_allocation_context *ac,
goto out;
/*
- * ac->ac2_order is set only if the fe_len is a power of 2
- * if ac2_order is set we also set criteria to 0 so that we
+ * ac->ac_2order is set only if the fe_len is a power of 2
+ * if ac->ac_2order is set we also set criteria to 0 so that we
* try exact allocation using buddy.
*/
i = fls(ac->ac_g_ex.fe_len);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment
2020-08-07 14:01 [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment brookxu
@ 2020-08-13 8:20 ` Andreas Dilger
2020-08-13 13:55 ` Ritesh Harjani
2020-08-18 18:14 ` Theodore Y. Ts'o
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Dilger @ 2020-08-13 8:20 UTC (permalink / raw)
To: brookxu; +Cc: Theodore Ts'o, Ext4 Developers List
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
> On Aug 7, 2020, at 8:01 AM, brookxu <brookxu.cn@gmail.com> wrote:
>
> Fix typos in ext4_mb_regular_allocator() comment
>
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> fs/ext4/mballoc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 4f21f34..0edec26 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2237,8 +2237,8 @@ static int ext4_mb_good_group_nolock(struct ext4_allocation_context *ac,
> goto out;
>
> /*
> - * ac->ac2_order is set only if the fe_len is a power of 2
> - * if ac2_order is set we also set criteria to 0 so that we
> + * ac->ac_2order is set only if the fe_len is a power of 2
> + * if ac->ac_2order is set we also set criteria to 0 so that we
> * try exact allocation using buddy.
> */
> i = fls(ac->ac_g_ex.fe_len);
> --
> 1.8.3.1
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment
2020-08-07 14:01 [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment brookxu
2020-08-13 8:20 ` Andreas Dilger
@ 2020-08-13 13:55 ` Ritesh Harjani
2020-08-18 18:14 ` Theodore Y. Ts'o
2 siblings, 0 replies; 4+ messages in thread
From: Ritesh Harjani @ 2020-08-13 13:55 UTC (permalink / raw)
To: brookxu, adilger.kernel, tytso, linux-ext4
On 8/7/20 7:31 PM, brookxu wrote:
> Fix typos in ext4_mb_regular_allocator() comment
>
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
Looks good to me.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment
2020-08-07 14:01 [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment brookxu
2020-08-13 8:20 ` Andreas Dilger
2020-08-13 13:55 ` Ritesh Harjani
@ 2020-08-18 18:14 ` Theodore Y. Ts'o
2 siblings, 0 replies; 4+ messages in thread
From: Theodore Y. Ts'o @ 2020-08-18 18:14 UTC (permalink / raw)
To: brookxu; +Cc: adilger.kernel, linux-ext4
On Fri, Aug 07, 2020 at 10:01:23PM +0800, brookxu wrote:
> Fix typos in ext4_mb_regular_allocator() comment
>
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-18 18:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-07 14:01 [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment brookxu
2020-08-13 8:20 ` Andreas Dilger
2020-08-13 13:55 ` Ritesh Harjani
2020-08-18 18:14 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).