* [PATCH] ext4: delete invalid comments near ext4_mb_check_limits()
@ 2020-08-07 14:01 brookxu
2020-08-13 15:35 ` Ritesh Harjani
2020-08-18 18:16 ` Theodore Y. Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: brookxu @ 2020-08-07 14:01 UTC (permalink / raw)
To: adilger.kernel, tytso, linux-ext4
These comments do not seem to be related to ext4_mb_check_limits(),
it may be invalid.
Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
fs/ext4/mballoc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 577ce98..aaefeb4 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1743,10 +1743,6 @@ static void ext4_mb_use_best_found(struct ext4_allocation_context *ac,
}
-/*
- * regular allocator, for general purposes allocation
- */
-
static void ext4_mb_check_limits(struct ext4_allocation_context *ac,
struct ext4_buddy *e4b,
int finish_group)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: delete invalid comments near ext4_mb_check_limits()
2020-08-07 14:01 [PATCH] ext4: delete invalid comments near ext4_mb_check_limits() brookxu
@ 2020-08-13 15:35 ` Ritesh Harjani
2020-08-18 18:16 ` Theodore Y. Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Ritesh Harjani @ 2020-08-13 15:35 UTC (permalink / raw)
To: brookxu, adilger.kernel, tytso, linux-ext4
On 8/7/20 7:31 PM, brookxu wrote:
> These comments do not seem to be related to ext4_mb_check_limits(),
> it may be invalid.
>
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
Either ways these comments are of no help and the
function has enough comments within.
So we should be good without it.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
> ---
> fs/ext4/mballoc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 577ce98..aaefeb4 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1743,10 +1743,6 @@ static void ext4_mb_use_best_found(struct ext4_allocation_context *ac,
>
> }
>
> -/*
> - * regular allocator, for general purposes allocation
> - */
> -
> static void ext4_mb_check_limits(struct ext4_allocation_context *ac,
> struct ext4_buddy *e4b,
> int finish_group)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: delete invalid comments near ext4_mb_check_limits()
2020-08-07 14:01 [PATCH] ext4: delete invalid comments near ext4_mb_check_limits() brookxu
2020-08-13 15:35 ` Ritesh Harjani
@ 2020-08-18 18:16 ` Theodore Y. Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2020-08-18 18:16 UTC (permalink / raw)
To: brookxu; +Cc: adilger.kernel, linux-ext4
On Fri, Aug 07, 2020 at 10:01:33PM +0800, brookxu wrote:
> These comments do not seem to be related to ext4_mb_check_limits(),
> it may be invalid.
>
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-18 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-07 14:01 [PATCH] ext4: delete invalid comments near ext4_mb_check_limits() brookxu
2020-08-13 15:35 ` Ritesh Harjani
2020-08-18 18:16 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).