From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: brookxu <brookxu.cn@gmail.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: optimize the implementation of ext4_mb_good_group()
Date: Tue, 18 Aug 2020 14:18:48 -0400 [thread overview]
Message-ID: <20200818181848.GD34125@mit.edu> (raw)
In-Reply-To: <e20b2d8f-1154-adb7-3831-a9e11ba842e9@gmail.com>
On Fri, Aug 07, 2020 at 10:01:39PM +0800, brookxu wrote:
> It might be better to adjust the code in two places:
> 1. Determine whether grp is currupt or not should be placed first.
> 2. (cr<=2 && free <ac->ac_g_ex.fe_len)should may belong to the crx
> strategy, and it may be more appropriate to put it in the
> subsequent switch statement block. For cr1, cr2, the conditions
> in switch potentially realize the above judgment. For cr0, we
> should add (free <ac->ac_g_ex.fe_len) judgment, and then delete
> (free / fragments) >= ac->ac_g_ex.fe_len), because cr0 returns
> true by default.
>
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2020-08-18 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 14:01 [PATCH] ext4: optimize the implementation of ext4_mb_good_group() brookxu
2020-08-12 22:15 ` Andreas Dilger
2020-08-13 15:31 ` Ritesh Harjani
2020-08-18 18:18 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818181848.GD34125@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=brookxu.cn@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).