* [PATCH] mballoc: Replace seq_printf with seq_puts
@ 2020-08-10 2:21 Xu Wang
2020-08-10 14:06 ` Ritesh Harjani
2020-08-18 18:22 ` Theodore Y. Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Xu Wang @ 2020-08-10 2:21 UTC (permalink / raw)
To: tytso, adilger.kernel, linux-ext4; +Cc: linux-kernel, Xu Wang
seq_puts is a lot cheaper than seq_printf, so use that to print
literal strings.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
fs/ext4/mballoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index c0a331e2feb0..77288e549a95 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2439,7 +2439,7 @@ static int ext4_mb_seq_groups_show(struct seq_file *seq, void *v)
for (i = 0; i <= 13; i++)
seq_printf(seq, " %-5u", i <= blocksize_bits + 1 ?
sg.info.bb_counters[i] : 0);
- seq_printf(seq, " ]\n");
+ seq_puts(seq, " ]\n");
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mballoc: Replace seq_printf with seq_puts
2020-08-10 2:21 [PATCH] mballoc: Replace seq_printf with seq_puts Xu Wang
@ 2020-08-10 14:06 ` Ritesh Harjani
2020-08-18 18:22 ` Theodore Y. Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Ritesh Harjani @ 2020-08-10 14:06 UTC (permalink / raw)
To: Xu Wang, tytso, adilger.kernel, linux-ext4; +Cc: linux-kernel
On 8/10/20 7:51 AM, Xu Wang wrote:
> seq_puts is a lot cheaper than seq_printf, so use that to print
> literal strings.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Looks good to me.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mballoc: Replace seq_printf with seq_puts
2020-08-10 2:21 [PATCH] mballoc: Replace seq_printf with seq_puts Xu Wang
2020-08-10 14:06 ` Ritesh Harjani
@ 2020-08-18 18:22 ` Theodore Y. Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2020-08-18 18:22 UTC (permalink / raw)
To: Xu Wang; +Cc: adilger.kernel, linux-ext4, linux-kernel
On Mon, Aug 10, 2020 at 02:21:58AM +0000, Xu Wang wrote:
> seq_puts is a lot cheaper than seq_printf, so use that to print
> literal strings.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-18 18:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-10 2:21 [PATCH] mballoc: Replace seq_printf with seq_puts Xu Wang
2020-08-10 14:06 ` Ritesh Harjani
2020-08-18 18:22 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).