From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Florian Schmaus <flo@geekplace.eu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] e4crypt: if salt is explicitly provided to add_key, then use it
Date: Thu, 1 Oct 2020 10:36:47 -0400 [thread overview]
Message-ID: <20201001143647.GI23474@mit.edu> (raw)
In-Reply-To: <20200707082729.85058-1-flo@geekplace.eu>
On Tue, Jul 07, 2020 at 10:27:30AM +0200, Florian Schmaus wrote:
> Providing -S and a path to 'add_key' previously exhibit an unintuitive
> behavior: instead of using the salt explicitly provided by the user,
> e4crypt would use the salt obtained via EXT4_IOC_GET_ENCRYPTION_PWSALT
> on the path. This was because set_policy() was still called with NULL
> as salt.
>
> With this change we now remember the explicitly provided salt (if any)
> and use it as argument for set_policy().
>
> Eventually
>
> e4crypt add_key -S s:my-spicy-salt /foo
>
> will now actually use 'my-spicy-salt' and not something else as salt
> for the policy set on /foo.
>
> Signed-off-by: Florian Schmaus <flo@geekplace.eu>
Applied, with the spell correction Eric pointed out.
- Ted
prev parent reply other threads:[~2020-10-01 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 19:47 [PATCH 1/3] e4crypt: if salt is explicitly provided to add_key, then use it Florian Schmaus
2020-07-06 19:47 ` [PATCH 2/3] e4crypt: refactor set_policy a little Florian Schmaus
2020-07-06 22:04 ` Eric Biggers
2020-07-06 19:47 ` [PATCH 3/3] Clarify in e4crypt man page that -S is an optional argument Florian Schmaus
2020-07-06 21:57 ` [PATCH 1/3] e4crypt: if salt is explicitly provided to add_key, then use it Eric Biggers
2020-07-07 8:36 ` Florian Schmaus
2020-07-07 21:40 ` Eric Biggers
2020-07-07 8:27 ` [PATCH v2] " Florian Schmaus
2020-07-07 21:47 ` Eric Biggers
2020-10-01 14:36 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001143647.GI23474@mit.edu \
--to=tytso@mit.edu \
--cc=flo@geekplace.eu \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).