From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: adilger@whamcloud.com
Cc: linux-ext4@vger.kernel.org, Andreas Dilger <adilger@dilger.ca>
Subject: Re: [PATCH] e2fsck: skip extent optimization by default
Date: Thu, 1 Oct 2020 14:03:36 -0400 [thread overview]
Message-ID: <20201001180336.GM23474@mit.edu> (raw)
In-Reply-To: <1600726562-9567-1-git-send-email-adilger@whamcloud.com>
On Mon, Sep 21, 2020 at 04:16:02PM -0600, adilger@whamcloud.com wrote:
> From: Andreas Dilger <adilger@whamcloud.com>
>
> The e2fsck error message:
>
> inode nnn extent tree (at level 1) could be narrower. Optimize<y>?
>
> can be fairly verbose at times, and leads users to think that there
> may be something wrong with the filesystem. Basically, almost any
> message printed by e2fsck makes users nervous when they are facing
> other corruption, and a few thousand of these printed may hide other
> errors. It also isn't clear that saving a few blocks optimizing the
> extent tree noticeably improves performance.
>
> This message has previously been annoying enough for Ted to add the
> "-E no_optimize_extents" option to disable it. Just enable this
> option by default, similar to the "-D" directory optimization option.
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Applying this patch causes a whole bunch of tests fail:
348 tests succeeded 9 tests failed
Tests failed: d_punch_bigalloc d_punch f_collapse_extent_tree
f_compress_extent_tree_level f_extent_bad_node f_extent_int_bad_magic
f_extent_leaf_bad_magic f_extent_oobounds f_quota_extent_opt
> @@ -1051,6 +1053,11 @@ static errcode_t PRS(int argc, char *argv[], e2fsck_t *ret_ctx)
> if (c)
> ctx->options |= E2F_OPT_NOOPT_EXTENTS;
>
> + profile_get_boolean(ctx->profile, "options", "optimize_extents",
> + 0, 0, &c);
> + if (c)
> + ctx->options &= ~E2F_OPT_NOOPT_EXTENTS;
> +
We already have a no_optimize_extents option supported in e2fsck.conf.
So if we want to change the default, a simpler way to do this might be
to edit e2fsck.conf.5.in to simply add "no_optimize_extents=true" to
the default version of e2fsck.conf defined by default.
As a reminder, for future changes, when we add a new tunable to
e2fsck.conf or mke2fs.conf, the man page should be edited. And please
do run the regression test suites before sending out a patch. Thanks!!
- Ted
next prev parent reply other threads:[~2020-10-01 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 22:16 [PATCH] e2fsck: skip extent optimization by default adilger
2020-09-22 10:26 ` Lukas Czerner
2020-09-22 17:42 ` Andreas Dilger
2020-09-23 11:00 ` Lukas Czerner
2020-10-01 18:03 ` Theodore Y. Ts'o [this message]
2020-10-02 2:11 ` Andreas Dilger
2020-10-02 3:04 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001180336.GM23474@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).