From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B0CC4741F for ; Thu, 1 Oct 2020 20:44:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A984620848 for ; Thu, 1 Oct 2020 20:44:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733093AbgJAUoC (ORCPT ); Thu, 1 Oct 2020 16:44:02 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:38111 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1733177AbgJAUnd (ORCPT ); Thu, 1 Oct 2020 16:43:33 -0400 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 091KhSqZ022276 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Oct 2020 16:43:29 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 4E14B42003C; Thu, 1 Oct 2020 16:43:28 -0400 (EDT) Date: Thu, 1 Oct 2020 16:43:28 -0400 From: "Theodore Y. Ts'o" To: Lukas Czerner Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 2/4] e2fsck: use size_t instead of int in string_copy() Message-ID: <20201001204328.GO23474@mit.edu> References: <20200605081442.13428-1-lczerner@redhat.com> <20200605081442.13428-2-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200605081442.13428-2-lczerner@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Jun 05, 2020 at 10:14:40AM +0200, Lukas Czerner wrote: > len argument in string_copy() is int, but it is used with malloc(), > strlen(), strncpy() and some callers use sizeof() to pass value in. So > it really ought to be size_t rather than int. Fix it. > > Signed-off-by: Lukas Czerner Thanks, applied. - Ted