Re: [PATCH v4] jbd2: avoid transaction reuse after reformatting

["Theodore Y. Ts'o" <tytso@mit.edu>]

On Thu, Oct 08, 2020 at 02:13:02PM -0600, Andreas Dilger wrote:
> On Oct 7, 2020, at 2:13 AM, Jan Kara <jack@suse.cz> wrote:
> > 
> > From: changfengnan <fengnanchang@foxmail.com>
> > 
> > When ext4 is formatted with lazy_journal_init=1 and transactions from
> > the previous filesystem are still on disk, it is possible that they are
> > considered during a recovery after a crash. Because the checksum seed
> > has changed, the CRC check will fail, and the journal recovery fails
> > with checksum error although the journal is otherwise perfectly valid.
> > Fix the problem by checking commit block time stamps to determine
> > whether the data in the journal block is just stale or whether it is
> > indeed corrupt.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Fengnan Chang <changfengnan@hikvision.com>
> > Signed-off-by: Jan Kara <jack@suse.cz>
> 
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> 
> NB: one trivial formatting cleanup if patch is refreshed
>

Applied, thanks.  I fixed the trivial format cleanup you pointed out,
plus a whitespace fix pointed out by checkpatch.

       		      	      	     - Ted