From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xiakaixu1987@gmail.com, linux-ext4@vger.kernel.org,
adilger.kernel@dilger.ca, Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [RFC PATCH] ext4: use the normal helper to get the actual inode
Date: Wed, 14 Oct 2020 11:48:58 -0400 [thread overview]
Message-ID: <20201014154858.GC18373@mit.edu> (raw)
In-Reply-To: <20201012093304.aevqpvq5sotzamrq@work>
On Mon, Oct 12, 2020 at 11:33:04AM +0200, Lukas Czerner wrote:
> On Sat, Oct 10, 2020 at 04:10:16PM +0800, xiakaixu1987@gmail.com wrote:
> > From: Kaixu Xia <kaixuxia@tencent.com>
> >
> > Here we use the READ_ONCE to fix race conditions in ->d_compare() and
> > ->d_hash() when they are called in RCU-walk mode, seems we can use
> > the normal helper d_inode_rcu() to get the actual inode.
>
> Looks good to me.
> Thanks!
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2020-10-14 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 8:10 [RFC PATCH] ext4: use the normal helper to get the actual inode xiakaixu1987
2020-10-12 9:33 ` Lukas Czerner
2020-10-14 15:48 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014154858.GC18373@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=kaixuxia@tencent.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).