Re: [PATCH v2] ext4: Detect already used quota file early

Theodore Y. Ts'o
2020-10-15T14:56:24Z

On Thu, Oct 15, 2020 at 01:03:30PM +0200, Jan Kara wrote:
> When we try to use file already used as a quota file again (for the same
> or different quota type), strange things can happen. At the very least
> lockdep annotations may be wrong but also inode flags may be wrongly set
> / reset. When the file is used for two quota types at once we can even
> corrupt the file and likely crash the kernel. Catch all these cases by
> checking whether passed file is already used as quota file and bail
> early in that case.
>
> This fixes occasional generic/219 failure due to lockdep complaint.
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> Reported-by: Ritesh Harjani <riteshh@linux.ibm.com>
> Signed-off-by: Jan Kara <jack@suse.cz>

Replied to the wrong patch previously. Thanks, applied.

- Ted