From: Xianting Tian <tian.xianting@h3c.com>
To: <tytso@mit.edu>, <adilger.kernel@dilger.ca>, <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Xianting Tian <tian.xianting@h3c.com>
Subject: [PATCH] ext4: remove the null check of bio_vec page
Date: Tue, 20 Oct 2020 16:22:01 +0800 [thread overview]
Message-ID: <20201020082201.34257-1-tian.xianting@h3c.com> (raw)
bv_page can't be NULL in a valid bio_vec, so we can remove the NULL check,
as we did in other places when calling bio_for_each_segment_all() to go
through all bio_vec of a bio.
Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
---
fs/ext4/page-io.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index defd2e10d..cb135a944 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -111,9 +111,6 @@ static void ext4_finish_bio(struct bio *bio)
unsigned under_io = 0;
unsigned long flags;
- if (!page)
- continue;
-
if (fscrypt_is_bounce_page(page)) {
bounce_page = page;
page = fscrypt_pagecache_page(bounce_page);
--
2.17.1
next reply other threads:[~2020-10-20 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 8:22 Xianting Tian [this message]
2020-10-21 10:25 ` [PATCH] ext4: remove the null check of bio_vec page Jan Kara
2020-10-23 16:38 ` Tianxianting
2020-10-23 16:56 ` Jan Kara
2020-12-03 8:16 ` Tianxianting
2020-12-03 14:11 ` Theodore Y. Ts'o
2020-12-04 1:27 ` Tianxianting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020082201.34257-1-tian.xianting@h3c.com \
--to=tian.xianting@h3c.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox