* [PATCH v3 23/32] jbd2: fix a kernel-doc markup [not found] <cover.1603791716.git.mchehab+huawei@kernel.org> @ 2020-10-27 9:51 ` Mauro Carvalho Chehab 2020-10-27 21:26 ` Theodore Y. Ts'o 0 siblings, 1 reply; 2+ messages in thread From: Mauro Carvalho Chehab @ 2020-10-27 9:51 UTC (permalink / raw) To: Linux Doc Mailing List, Jonathan Corbet Cc: Mauro Carvalho Chehab, Theodore Ts'o, Harshad Shirwadkar, Jan Kara, linux-ext4, linux-kernel The kernel-doc markup that documents _fc_replay_callback is missing an asterisk, causing this warning: ../include/linux/jbd2.h:1271: warning: Function parameter or member 'j_fc_replay_callback' not described in 'journal_s' When building the docs. Fixes: 609f928af48f ("jbd2: fast commit recovery path") Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- include/linux/jbd2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h index fb3d71ad6eea..3c5f76ce88f1 100644 --- a/include/linux/jbd2.h +++ b/include/linux/jbd2.h @@ -1253,7 +1253,7 @@ struct journal_s */ void (*j_fc_cleanup_callback)(struct journal_s *journal, int); - /* + /** * @j_fc_replay_callback: * * File-system specific function that performs replay of a fast -- 2.26.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 23/32] jbd2: fix a kernel-doc markup 2020-10-27 9:51 ` [PATCH v3 23/32] jbd2: fix a kernel-doc markup Mauro Carvalho Chehab @ 2020-10-27 21:26 ` Theodore Y. Ts'o 0 siblings, 0 replies; 2+ messages in thread From: Theodore Y. Ts'o @ 2020-10-27 21:26 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List, Jonathan Corbet, Harshad Shirwadkar, Jan Kara, linux-ext4, linux-kernel On Tue, Oct 27, 2020 at 10:51:27AM +0100, Mauro Carvalho Chehab wrote: > The kernel-doc markup that documents _fc_replay_callback is > missing an asterisk, causing this warning: > > ../include/linux/jbd2.h:1271: warning: Function parameter or member 'j_fc_replay_callback' not described in 'journal_s' > > When building the docs. > > Fixes: 609f928af48f ("jbd2: fast commit recovery path") > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Thanks, I'm accomulating some bug fix patches to push to Linus, so I'll grab this for the ext4 git tree. - Ted ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-27 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1603791716.git.mchehab+huawei@kernel.org>
2020-10-27 9:51 ` [PATCH v3 23/32] jbd2: fix a kernel-doc markup Mauro Carvalho Chehab
2020-10-27 21:26 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).