From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Luo Meng <luomeng12@huawei.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, jack@suse.cz
Subject: Re: [PATCH] ext4: fix invalid inode checksum
Date: Tue, 27 Oct 2020 23:38:39 -0400 [thread overview]
Message-ID: <20201028033839.GK5691@mit.edu> (raw)
In-Reply-To: <20201020013631.3796673-1-luomeng12@huawei.com>
On Tue, Oct 20, 2020 at 09:36:31AM +0800, Luo Meng wrote:
> During the stability test, there are some errors:
> ext4_lookup:1590: inode #6967: comm fsstress: iget: checksum invalid.
>
> If the inode->i_iblocks too big and doesn't set huge file flag, checksum
> will not be recalculated when update the inode information to it's buffer.
> If other inode marks the buffer dirty, then the inconsistent inode will
> be flushed to disk.
>
> Fix this problem by checking i_blocks in advance.
>
> Signed-off-by: Luo Meng <luomeng12@huawei.com>
Thanks, this has been applied.
- Ted
prev parent reply other threads:[~2020-10-28 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 1:36 [PATCH] ext4: fix invalid inode checksum Luo Meng
2020-10-20 3:59 ` Darrick J. Wong
2020-10-28 3:38 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028033839.GK5691@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=luomeng12@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).