From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A08F5C388F7 for ; Wed, 28 Oct 2020 21:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A59524857 for ; Wed, 28 Oct 2020 21:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725837AbgJ1VdA (ORCPT ); Wed, 28 Oct 2020 17:33:00 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:56435 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725827AbgJ1Vcx (ORCPT ); Wed, 28 Oct 2020 17:32:53 -0400 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 09S3uhbe025303 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Oct 2020 23:56:43 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 1C10C420107; Tue, 27 Oct 2020 23:56:43 -0400 (EDT) Date: Tue, 27 Oct 2020 23:56:43 -0400 From: "Theodore Y. Ts'o" To: Jan Kara Cc: linux-ext4@vger.kernel.org, Mauricio Faria de Oliveira Subject: Re: [PATCH] ext4: Fix mmap write protection for data=journal mode Message-ID: <20201028035643.GP5691@mit.edu> References: <20201027132751.29858-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027132751.29858-1-jack@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Oct 27, 2020 at 02:27:51PM +0100, Jan Kara wrote: > Commit afb585a97f81 "ext4: data=journal: write-protect pages on > j_submit_inode_data_buffers()") added calls ext4_jbd2_inode_add_write() > to track inode ranges whose mappings need to get write-protected during > transaction commits. However the added calls use wrong start of a range > (0 instead of page offset) and so write protection is not necessarily > effective. Use correct range start to fix the problem. > > Fixes: afb585a97f81 ("ext4: data=journal: write-protect pages on j_submit_inode_data_buffers()") > Signed-off-by: Jan Kara Thanks, applied. - Ted