Re: [PATCH 06/34] fs: add id translation helpers

Christian Brauner
2020-11-02T13:25:28Z

On Sun, Nov 01, 2020 at 02:46:32PM +0000, Christoph Hellwig wrote:
> > +static inline kuid_t kuid_into_mnt(struct user_namespace *to, kuid_t kuid)
> > +{
> > +#ifdef CONFIG_IDMAP_MOUNTS
> > + return make_kuid(to, __kuid_val(kuid));
> > +#else
> > + return kuid;
> > +#endif
> > +}
> > +
> > +static inline kgid_t kgid_into_mnt(struct user_namespace *to, kgid_t kgid)
> > +{
> > +#ifdef CONFIG_IDMAP_MOUNTS
> > + return make_kgid(to, __kgid_val(kgid));
> > +#else
> > + return kgid;
> > +#endif
>
> If you want to keep the config option please at least have on
> #ifdef/#else/#endif instead of this mess.

Understood.