From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCB54C2D0A3 for ; Fri, 6 Nov 2020 17:51:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74483217A0 for ; Fri, 6 Nov 2020 17:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604685062; bh=AoXlPZXpHyAt8nSZY7QrSbqoHAJncxCabKt0S2lrriE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gJR1A+Rx6V6TPeD5gGmY6e8W6n6i/Evf88axWZpxNSPNUgEqhG8TyJbDVlwl/NeRF QdPlARLw+1oJ8axvNi02u9CSZ+UXyF4KNB1YvXat45CIGPRxux5+bJt/Uvo1U+4gKj lgF0PepbOsGzKWKGzPMJ2s2x+Ssmm6To8LlMAoVo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727605AbgKFRvB (ORCPT ); Fri, 6 Nov 2020 12:51:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:55502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726408AbgKFRvB (ORCPT ); Fri, 6 Nov 2020 12:51:01 -0500 Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE8FD2151B; Fri, 6 Nov 2020 17:51:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604685061; bh=AoXlPZXpHyAt8nSZY7QrSbqoHAJncxCabKt0S2lrriE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OMFdoB+qGBJDUSXBs3zEFsHYY4+pvgORPQDZbY6oVtzoO/QYTzJjqE9u2Sy4ve+58 5J3MT3T8ac5TaiVKiqX4ZsW1kjIMkGzOrG+0R1OT1GvMraUsjEqiChTwvglKF7fpbh JmGwNhpqXmYDjT2XwIYcrio9l02m4Msm/KyP88BM= Date: Fri, 6 Nov 2020 09:50:59 -0800 From: Eric Biggers To: linux-fscrypt@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "Theodore Y. Ts'o" Subject: Re: [PATCH] fscrypt: remove reachable WARN in fscrypt_setup_iv_ino_lblk_32_key() Message-ID: <20201106175059.GD845@sol.localdomain> References: <20201031004556.87862-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201031004556.87862-1-ebiggers@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Oct 30, 2020 at 05:45:56PM -0700, Eric Biggers wrote: > From: Eric Biggers > > I_CREATING isn't actually set until the inode has been assigned an inode > number and inserted into the inode hash table. So the WARN_ON() in > fscrypt_setup_iv_ino_lblk_32_key() is wrong, and it can trigger when > creating an encrypted file on ext4. Remove it. > > This was sometimes causing xfstest generic/602 to fail on ext4. I > didn't notice it before because due to a separate oversight, new inodes > that haven't been assigned an inode number yet don't necessarily have > i_ino == 0 as I had thought, so by chance I never saw the test fail. > > Fixes: a992b20cd4ee ("fscrypt: add fscrypt_prepare_new_inode() and fscrypt_set_context()") > Reported-by: Theodore Y. Ts'o > Signed-off-by: Eric Biggers Applied to fscrypt.git#for-stable for 5.10. - Eric