From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: David Gow <davidgow@google.com>, Marco Elver <elver@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Arpitha Raghunandan <98.arpi@gmail.com>,
Iurii Zaikin <yzaikin@google.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"Bird, Tim" <Tim.Bird@sony.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH v9 1/2] kunit: Support for Parameterized Testing
Date: Wed, 2 Dec 2020 11:02:14 -0500 [thread overview]
Message-ID: <20201202160214.GA390058@mit.edu> (raw)
In-Reply-To: <CAFd5g4768o7UtOmM3X0X5upD0uF3j-=g3txi0_Ue3z8oM_Ghow@mail.gmail.com>
On Mon, Nov 30, 2020 at 02:22:22PM -0800, 'Brendan Higgins' via KUnit Development wrote:
>
> Looks good to me. I would definitely like to pick this up. But yeah,
> in order to pick up 2/2 we will need an ack from either Ted or Iurii.
>
> Ted seems to be busy right now, so I think I will just ask Shuah to go
> ahead and pick this patch up by itself and we or Ted can pick up patch
> 2/2 later.
I have been paying attention to this patch series, but I had presumed
that this was much more of a kunit change than an ext4 change, and the
critical bits was a review of the kunit infrastructure. I certainly
have no objection to changing the ext4 test to use the new
parameterized testing, and if you'd like me to give a quick review,
I'll take a quick look. I assume, Brendan, that you've already tried
doing a compile and run test of the patch series, so I'm not going to
do that?
- Ted
prev parent reply other threads:[~2020-12-02 16:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 5:40 [PATCH v9 1/2] kunit: Support for Parameterized Testing Arpitha Raghunandan
2020-11-16 5:41 ` [PATCH v9 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature Arpitha Raghunandan
2020-11-16 8:51 ` Marco Elver
2020-11-17 7:22 ` David Gow
2020-12-01 20:30 ` Iurii Zaikin
2020-12-02 16:07 ` Theodore Y. Ts'o
2020-12-02 22:59 ` Shuah Khan
2020-11-16 8:53 ` [PATCH v9 1/2] kunit: Support for Parameterized Testing Marco Elver
2020-11-17 7:20 ` David Gow
2020-11-23 13:08 ` Marco Elver
2020-11-24 7:25 ` David Gow
2020-11-24 8:02 ` Marco Elver
2020-11-30 22:22 ` Brendan Higgins
2020-12-01 22:28 ` Shuah Khan
2020-12-01 23:31 ` Marco Elver
2020-12-02 22:58 ` Shuah Khan
2020-12-02 16:02 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202160214.GA390058@mit.edu \
--to=tytso@mit.edu \
--cc=98.arpi@gmail.com \
--cc=Tim.Bird@sony.com \
--cc=adilger.kernel@dilger.ca \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=elver@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).