From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C031C00AA1 for ; Thu, 3 Dec 2020 14:44:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26F1522D5B for ; Thu, 3 Dec 2020 14:44:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729953AbgLCOoC (ORCPT ); Thu, 3 Dec 2020 09:44:02 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:34667 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729039AbgLCOoB (ORCPT ); Thu, 3 Dec 2020 09:44:01 -0500 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0B3EhBlN004897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 3 Dec 2020 09:43:11 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 32F9E420136; Thu, 3 Dec 2020 09:43:11 -0500 (EST) Date: Thu, 3 Dec 2020 09:43:11 -0500 From: "Theodore Y. Ts'o" To: Chunguang Xu Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Subject: Re: [PATCH RESEND 3/8] ext4: simplify the code of mb_find_order_for_block Message-ID: <20201203144311.GL441757@mit.edu> References: <1604764698-4269-1-git-send-email-brookxu@tencent.com> <1604764698-4269-3-git-send-email-brookxu@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1604764698-4269-3-git-send-email-brookxu@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Nov 07, 2020 at 11:58:13PM +0800, Chunguang Xu wrote: > From: Chunguang Xu > > The code of mb_find_order_for_block is a bit obscure, but we can > simplify it with mb_find_buddy(), make the code more concise. > > Signed-off-by: Chunguang Xu > Reviewed-by: Andreas Dilger Thanks, applied. - Ted