From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Saranya Muruganandam <saranyamohan@google.com>,
Wang Shilong <wshilong@ddn.com>
Subject: Re: [PATCH RFC 5/5] Enable threaded support for e2fsprogs' applications.
Date: Fri, 11 Dec 2020 17:37:23 -0500 [thread overview]
Message-ID: <20201211223723.GD575698@mit.edu> (raw)
In-Reply-To: <89A599C9-4978-43C9-B2B4-82C9E746AC39@dilger.ca>
On Thu, Dec 10, 2020 at 09:10:09PM -0700, Andreas Dilger wrote:
> On Dec 4, 2020, at 9:58 PM, Theodore Ts'o <tytso@mit.edu> wrote:
> >
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
>
> My understanding is that as soon as the EXT2_FLAG_THREADS is added,
> and if the backend supports CHANNEL_FLAGS_THREADS, then the pthread
> code in the previous patch will "autothread" based on the number of
> CPUs in the system.
Yep.
> That will be nice for debugfs, which would otherwise take ages to
> start on a large filesystem if "-c" was not used (which also
> precludes any kind of modifications).
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Yes, that's an issue that our SRE's have run across as well while
debugging customer problems, which is one of the reasons why I've been
interested in getting this change upstream first, even it takes a bit
longer to get all of the parallel fsck changes reviewed and upstream.
- Ted
prev parent reply other threads:[~2020-12-11 23:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 4:58 [PATCH RFC 0/5] Add threading support to e2fsprogs Theodore Ts'o
2020-12-05 4:58 ` [PATCH RFC 1/5] Add configure and build support for the pthreads library Theodore Ts'o
2020-12-05 4:58 ` [PATCH RFC 2/5] libext2fs: add threading support to the I/O manager abstraction Theodore Ts'o
2020-12-07 18:15 ` Andreas Dilger
2020-12-08 1:17 ` Theodore Y. Ts'o
2020-12-05 4:58 ` [PATCH RFC 3/5] libext2fs: allow the unix_io manager's cache to be disabled and re-enabled Theodore Ts'o
2020-12-05 4:58 ` [PATCH RFC 4/5] ext2fs: parallel bitmap loading Theodore Ts'o
2020-12-11 0:12 ` Andreas Dilger
2020-12-11 22:35 ` Theodore Y. Ts'o
2020-12-05 4:58 ` [PATCH RFC 5/5] Enable threaded support for e2fsprogs' applications Theodore Ts'o
2020-12-11 4:10 ` Andreas Dilger
2020-12-11 22:37 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211223723.GD575698@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=saranyamohan@google.com \
--cc=wshilong@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).