From: Jan Kara <jack@suse.cz>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, Andreas Dilger <adilger@dilger.ca>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] mke2fs.8: Improve valid block size documentation
Date: Wed, 16 Dec 2020 11:22:13 +0100 [thread overview]
Message-ID: <20201216102213.GC21258@quack2.suse.cz> (raw)
In-Reply-To: <X9kFc9S/JnHBWXsY@mit.edu>
On Tue 15-12-20 13:50:27, Theodore Y. Ts'o wrote:
> On Thu, Oct 15, 2020 at 11:27:31AM +0200, Jan Kara wrote:
> > On Wed 14-10-20 18:56:13, Andreas Dilger wrote:
> > > On Oct 13, 2020, at 7:38 AM, Jan Kara <jack@suse.cz> wrote:
> > > >
> > > > Explain which valid block sizes mke2fs supports in more detail.
> > > >
> > > > Signed-off-by: Jan Kara <jack@suse.cz>
> > >
> > > Should this mention that the default block size is 4096 bytes for most
> > > filesystems?
> >
> > That would be to the "heuristic" parts. Yes, I agree, I'll add that.
> >
> > > It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this
> > > is definitely an improvement already.
> >
> > Yeah, I can add that to the "page size" part. But with these archs there's
> > a catch that page size can be configured in the kernel config so the
> > formulation will need to be a bit more careful. But I'll add something.
> >
> > > Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> >
> > Thanks! I'll send v2.
>
> Did you ever send a v2 of this patch? I can't seem to find it in my
> archives or in patchwork.
I think I did but probably it got lost somewhere. Anyway, I've resent it
now. Thanks for noticing!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-12-16 10:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 13:38 [PATCH] mke2fs.8: Improve valid block size documentation Jan Kara
2020-10-15 0:56 ` Andreas Dilger
2020-10-15 9:27 ` Jan Kara
2020-12-15 18:50 ` Theodore Y. Ts'o
2020-12-16 10:22 ` Jan Kara [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-16 10:22 Jan Kara
2021-01-21 23:26 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216102213.GC21258@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).