From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707F6C433DB for ; Fri, 8 Jan 2021 09:28:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C8BC233EA for ; Fri, 8 Jan 2021 09:28:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728062AbhAHJ1n (ORCPT ); Fri, 8 Jan 2021 04:27:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:51240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727416AbhAHJ1m (ORCPT ); Fri, 8 Jan 2021 04:27:42 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D459623383; Fri, 8 Jan 2021 09:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610098021; bh=OK/mYSs9iM/Xc5hxkZH354NtxXCpKfdWVjsPjgRbISk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C5qyhiKjMN7La52qc6rSqYAOnndCr76SYaP4nS6fmGU4KOHTk7A9TbGUuWuP47r2i 7K81EAa64FipzxuKipWJx2HAi9c41nOqvh7XWK2F8/Q8ioih0CkDJOIuNr97Sd059s fwQz1R6BcTeHg/wuO4Y006iJdGIR9VLJNCjXxsrvkIlZ/FQpsMFVauV8FA73sDUNVY owqzKKU4zPGpaEZZqrqik0Uve0hmVAZ2i4Lvc5KIseuYQ5i/QsYOPOfIPwS7IimOkL ejnpVJIy37QEIEs6YiasyhF33mldMpxfo0qTWnYiE9gM6mwpbsPJcZtqD9S7R2zSQu vpjjsMgaI6yvQ== Date: Fri, 8 Jan 2021 09:26:56 +0000 From: Will Deacon To: Peter Zijlstra Cc: Arnd Bergmann , Russell King - ARM Linux admin , linux-toolchains@vger.kernel.org, Mark Rutland , Theodore Ts'o , "linux-kernel@vger.kernel.org" , Andreas Dilger , Ext4 Developers List , Linux ARM , Linus Torvalds Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Message-ID: <20210108092655.GA4031@willie-the-truck> References: <20210106115359.GB26994@C02TD0UTHF1T.local> <20210106135253.GJ1551@shell.armlinux.org.uk> <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Jan 08, 2021 at 10:21:54AM +0100, Peter Zijlstra wrote: > On Thu, Jan 07, 2021 at 10:20:38PM +0100, Arnd Bergmann wrote: > > On Thu, Jan 7, 2021 at 2:37 PM Russell King - ARM Linux admin > > > > So, do we raise the minimum gcc version for the kernel as a whole to 5.1 > > > or just for aarch64? > > > > I'd personally love to see gcc-5 as the global minimum version, as that > > would let us finally use --std=gnu11 features instead of gnu89. [There are > > a couple of useful features that are incompatible with gnu89, and > > gnu99/gnu11 support in gcc didn't like the kernel sources] > > +1 for raising the tree-wide minimum (again!). We actually have a bunch > of work-arounds for 4.9 bugs we can get rid of as well. We even just added another one for arm64 KVM! [1] So yes, I'm in favour of leaving gcc 4.9 to rot as well, especially after this ext4 debugging experience. Will [1] https://git.kernel.org/linus/9fd339a45be5