Re: [PATCH v3 00/11] lazytime fix and cleanups

Eric Biggers
2021-01-13T18:50:29Z

On Wed, Jan 13, 2021 at 05:29:58PM +0100, Jan Kara wrote:
> Hello!
>
> On Tue 12-01-21 11:02:42, Eric Biggers wrote:
> > Patch 1 fixes a bug in how __writeback_single_inode() handles lazytime
> > expirations. I originally reported this last year
> > (https://lore.kernel.org/r/20200306004555.GB225345@gmail.com) because it
> > causes the FS_IOC_REMOVE_ENCRYPTION_KEY ioctl to not work properly, as
> > the bug causes inodes to remain dirty after a sync.
> >
> > It also turns out that lazytime on XFS is partially broken because it
> > doesn't actually write timestamps to disk after a sync() or after
> > dirtytime_expire_interval. This is fixed by the same fix.
> >
> > This supersedes previously proposed fixes, including
> > https://lore.kernel.org/r/20200307020043.60118-1-tytso@mit.edu and
> > https://lore.kernel.org/r/20200325122825.1086872-3-hch@lst.de from last
> > year (which had some issues and didn't fix the XFS bug), and v1 of this
> > patchset which took a different approach
> > (https://lore.kernel.org/r/20210105005452.92521-1-ebiggers@kernel.org).
> >
> > Patches 2-11 then clean up various things related to lazytime and
> > writeback, such as clarifying the semantics of ->dirty_inode() and the
> > inode dirty flags, and improving comments.
> >
> > This patchset applies to v5.11-rc2.
>
> Thanks for the patches. I've picked the patches to my tree. I plan to push
> patch 1/11 to Linus later this week, the rest of the cleanups will go to
> him during the next merge window.
>
> Honza

Sounds good, thanks!

- Eric